Merge pull request #54 from membraneframework/jb/fix-nil-nalu-splitte…

…r-on-eos Prevent accessing `nil` NALu splitter/parser on end of stream
membraneframework · Dec 8, 2023 · 5fe0648 · 5fe0648
2 parents 9de3f90 + 0430999
commit 5fe0648
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -22,7 +22,7 @@ The package can be installed by adding `membrane_h264_plugin` to your list of de
 ```elixir
 def deps do
   [
-    {:membrane_h264_plugin, "~> 0.9.0"}
+    {:membrane_h264_plugin, "~> 0.9.1"}
   ]
 end
 ```

diff --git a/lib/membrane_h264_plugin/parser.ex b/lib/membrane_h264_plugin/parser.ex
@@ -305,7 +305,8 @@ defmodule Membrane.H264.Parser do
   end
 
   @impl true
-  def handle_end_of_stream(:input, ctx, state) when state.mode != :au_aligned do
+  def handle_end_of_stream(:input, ctx, state)
+      when state.mode != :au_aligned and ctx.pads.input.start_of_stream? do
     {last_nalu_payload, nalu_splitter} = NALuSplitter.split(<<>>, true, state.nalu_splitter)
     {last_nalu, nalu_parser} = NALuParser.parse_nalus(last_nalu_payload, state.nalu_parser)
     {maybe_improper_aus, au_splitter} = AUSplitter.split(last_nalu, true, state.au_splitter)

diff --git a/mix.exs b/mix.exs
@@ -1,8 +1,8 @@
 defmodule Membrane.H264.Plugin.Mixfile do
   use Mix.Project
 
-  @version "0.9.0"
-  @github_url "https://github.com/membraneframework-labs/membrane_h264_plugin"
+  @version "0.9.1"
+  @github_url "https://github.com/membraneframework/membrane_h264_plugin"
 
   def project do
     [