Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output_alignment option #33

Merged
merged 7 commits into from
Jul 11, 2023
Merged

Add output_alignment option #33

merged 7 commits into from
Jul 11, 2023

Conversation

varsill
Copy link
Contributor

@varsill varsill commented Jun 21, 2023

This PR adds an output_alignment option that allows to specify if the in a single output buffer it should be a NAL unit or an access unit.

…at with appropriate alignment depending on options. Add part of test checking if the valid stream format is sent
@varsill varsill requested a review from mat-hek June 21, 2023 11:34
@@ -81,7 +81,8 @@ defmodule Membrane.H264.Parser.Format do
| width: width,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really related, but let's get rid of this @default_format

@mat-hek mat-hek merged commit e2a7b47 into master Jul 11, 2023
3 checks passed
@mat-hek mat-hek deleted the nalu_aligned_mode branch July 11, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants