Timestamps for B frames #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-hek
force-pushed
the
timestamps-b-frames
branch
from
af27eeb
to
58e881b
Compare
varsill
requested changes
Aug 8, 2023
lib/membrane_h264_plugin/parser.ex
Outdated
| @@ -319,40 +327,62 @@ defmodule Membrane.H264.Parser do | |||
| output_alignment: state.output_alignment | |||
| ) | |||
|
|
|||
| {[stream_format: {:output, fmt}], fmt.profile} | |||
| max_frame_reorder = if fmt.profile in [:baseline, :constrained_baseline], do: 0, else: 15 | |||
There was a problem hiding this comment.
As discussed, that can cause some problems when the profile is changed during the stream run
mat-hek
force-pushed
the
timestamps-b-frames
branch
2 times, most recently
from
3cf513c
to
58e881b
Compare
Co-authored-by: Łukasz Kita <lukasz.kita0@gmail.com>
varsill
reviewed
Aug 10, 2023
lib/membrane_h264_plugin/parser.ex
Outdated
| description: """ | ||
| Generates timestamps based on given `framerate`. | ||
|
|
||
| This option works only when `Membrane.RemoteStream` format arrives on |
There was a problem hiding this comment.
We can add some warning when other format arrives and generate_best_effort_timestamps: true is set, that the option has no effect
There was a problem hiding this comment.
We could, but then we would warn if somebody had the same parser config for different inputs
varsill
reviewed
Aug 10, 2023
varsill
approved these changes
Aug 16, 2023
| %{au_counter: au_counter, key_frame_au_idx: key_frame_au_idx} = state | ||
| first_vcl_nalu = Enum.find(au, &NALuTypes.is_vcl_nalu_type(&1.type)) | ||
| {poc, state} = calculate_poc(first_vcl_nalu, state) | ||
| key_frame_au_idx = if poc == 0, do: au_counter, else: key_frame_au_idx | ||
| pts = div((key_frame_au_idx + poc) * seconds * Membrane.Time.second(), frames) | ||
| max_frame_reorder = if Map.get(config, :add_dts_offset, true), do: 15, else: 0 |
There was a problem hiding this comment.
let's parametrize that magic number 15. I would also consider "parsing" that add_dts_offset option in handle_init (by which I mean that we can set its default value there)
mat-hek
force-pushed
the
timestamps-b-frames
branch
2 times, most recently
from
7370eec
to
a91eaf1
Compare
mat-hek
force-pushed
the
timestamps-b-frames
branch
from
a91eaf1
to
3ff0b46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
max_frame_reorderoption