Add hacky NALU completion handling #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-hek
requested changes
Aug 9, 2023
varsill
reviewed
Aug 9, 2023
mat-hek
approved these changes
Aug 10, 2023
varsill
approved these changes
Aug 10, 2023
bblaszkow06
reviewed
Aug 10, 2023
| # | ||
| # It happens that some streams have broken frame numbers (that are either non-monotically | ||
| # increasing or just reset on a key frame) but the `first_mb_in_slice` set to zero can mean that | ||
| # we are dealin with a new AU (given a proper `nal_unit_type`). It seems that it is sufficient |
There was a problem hiding this comment.
Suggested change
| # we are dealin with a new AU (given a proper `nal_unit_type`). It seems that it is sufficient | |
| # we are dealing with a new AU (given a proper `nal_unit_type`). It seems that it is sufficient |
| # | ||
| # NOTE: The following check is not a part of the original H264 specification unlike the other checks below. | ||
| # | ||
| # It happens that some streams have broken frame numbers (that are either non-monotically |
There was a problem hiding this comment.
Suggested change
| # It happens that some streams have broken frame numbers (that are either non-monotically | |
| # It happens that some streams have broken frame numbers (that are either non-monotonically |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for AU completion detection that works in mysterious ways (taken from GStreamer).
https://github.com/GStreamer/gst-plugins-bad/blob/ca8068c6d793d7aaa6f2e2cc6324fdedfe2f33fa/gst/videoparsers/gsth264parse.c#L1183C45-L1185C49