Fix chunk offsets #110
Merged
Fix chunk offsets #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…value per each sample. Consume the mdat iterator while reading data from mdat
…of mdat data. Calculate start of mdat based on this function.
mat-hek
requested changes
Apr 22, 2024
Comment on lines
68
to
72
| # data = | ||
| # case data do | ||
| # <<0, 0, 0, 0, 0, 0, 0, 0, rest::binary>> -> rest | ||
| # _other -> data | ||
| # end |
Comment on lines
225
to
226
| sample = | ||
| Map.put(sample, :track_id, track_id) |> Map.put(:chunk_offset, chunk_offset) |
There was a problem hiding this comment.
We could accumulate the offset of each chunk here
lib/membrane_mp4/demuxer/isom.ex
Outdated
| @@ -141,12 +142,15 @@ defmodule Membrane.MP4.Demuxer.ISOM do | |||
| fsm_state: :samples_info_present_and_all_pads_connected | |||
| } = state | |||
| ) do | |||
| {samples, rest, samples_info} = | |||
| SamplesInfo.get_samples(state.samples_info, state.partial <> buffer.payload) | |||
| {samples, {rest, rest_iterator}, samples_info} = | |||
There was a problem hiding this comment.
The rest_iterator could be initialized in SamplesInfo.get_samples_info and kept in samples_info
…mposition_offset. Add tests.
…nt to the beggining of mdat's header.
mat-hek
approved these changes
Apr 23, 2024
lib/membrane_mp4/demuxer/isom.ex
Outdated
Comment on lines
211
to
213
| {state.mdat_beginning || get_mdat_header_beginning(state.boxes), | ||
| state.mdat_header_size || maybe_header[:header_size] || state.boxes[:mdat].header_size, | ||
| state.mdat_size || maybe_header[:content_size] || state.boxes[:mdat].size} |
Comment on lines
74
to
75
| if to_skip + size <= byte_size(data) do | ||
| <<_to_skip::binary-size(to_skip), payload::binary-size(size), rest::binary>> = data |
There was a problem hiding this comment.
It would look better as a case
Suggested change
| if to_skip + size <= byte_size(data) do | |
| <<_to_skip::binary-size(to_skip), payload::binary-size(size), rest::binary>> = data | |
| case data do | |
| <<_to_skip::binary-size(to_skip), payload::binary-size(size), rest::binary>> -> |
Comment on lines
91
to
93
| [ | ||
| buffer | buffers | ||
| ] |
There was a problem hiding this comment.
Suggested change
| [ | |
| buffer | buffers | |
| ] | |
| [buffer | buffers] |
Comment on lines
217
to
219
| Map.put(sample, :track_id, track_id) | ||
| |> Map.put(:chunk_offset, chunk_offset) | ||
| |> Map.put(:sample_offset, sample_offset) |
varsill
added a commit
that referenced
this pull request
Apr 25, 2024
* Add support for version1 boxes. Add parsing of co64 box * Fix chunk offsets (#110) * bump to v0.34.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.