Develop #2
Merged
Develop #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bblaszkow06
requested changes
Apr 29, 2020
|
CI will be fixed once the new docker is ready |
bblaszkow06
reviewed
May 18, 2020
lib/membrane_opus.ex
Outdated
| """ | ||
| @type fec_enabled_t :: boolean | ||
| @type fec_available_t :: boolean | nil |
There was a problem hiding this comment.
Is this actually needed? I haven't found a way to detect that FEC is enabled, so for RTP received streams we'll never know and when encoding it is enough to set it as encoder option
@mat-hek what's missing in the image I made? :) |
|
@mkaput I suppose it wasn't finished 11 days ago, now its added to CI and nothing seems to be missing :P |
bblaszkow06
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.