add self_delimiting? field #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickel8
reviewed
Oct 29, 2020
lib/membrane_opus.ex
Outdated
| @@ -20,12 +20,9 @@ defmodule Membrane.Opus do | |||
|
|
|||
| @type t :: %__MODULE__{ | |||
| bitrate: bitrate_t, | |||
| channels: channels_t | |||
| channels: channels_t, | |||
| self_delimiting?: boolean | |||
There was a problem hiding this comment.
We have documented what are bitrate and channels so maybe let's do sth similar with self_delimiting?.
mickel8
reviewed
Oct 29, 2020
lib/membrane_opus.ex
Outdated
| :channels | ||
| ] | ||
| defstruct @enforce_keys | ||
| defstruct [:bitrate, :channels, self_delimiting?: false] |
There was a problem hiding this comment.
Shouldn't there be any defaults?
There was a problem hiding this comment.
The defaults are nil, meaning they are unknown
mat-hek
force-pushed
the
self_delimiting
branch
from
e230170
to
6a70390
Compare
mat-hek
changed the title
mickel8
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.