Move to membrane_raw_audio_format | MS-39 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bblaszkow06
reviewed
Mar 16, 2022
| @@ -36,15 +36,15 @@ defmodule Membrane.Opus.Plugin.Mixfile do | |||
| defp deps do | |||
| [ | |||
| {:bunch, "~> 1.3"}, | |||
| {:membrane_core, "~> 0.8.0"}, | |||
| {:membrane_core, "~> 0.9.0"}, | |||
There was a problem hiding this comment.
Split that into 2 MRs and releases. The core update should come first and include migration to auto-demands. See membraneframework/membrane_ffmpeg_video_filter_plugin#6 for reference
daniel-jodlos
force-pushed
the
MS-39-membrane_opus_plugin-caps-format
branch
from
b7e9d8b
to
7ec6b51
Compare
bblaszkow06
approved these changes
Mar 22, 2022
| @@ -38,7 +38,7 @@ defmodule Membrane.Opus.Plugin.Mixfile do | |||
| {:bunch, "~> 1.3"}, | |||
| {:membrane_core, "~> 0.9.0"}, | |||
| {:membrane_opus_format, "~> 0.3.0"}, | |||
| {:membrane_caps_audio_raw, "~> 0.6.0"}, | |||
There was a problem hiding this comment.
You may do the usual housekeeping before the release -
Apache-2.0(with dash) licenseformatters: ["html"]for docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.