Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurability for precompiled deps usage #52

Closed
wants to merge 1 commit into from

Conversation

anzaika
Copy link

@anzaika anzaika commented Oct 19, 2023

Hi!

I figured sometimes you just want to use the binaries already present on your system. So this configurability should be worth it. Please let me know what you think.

As always many thanks for all the insanely work you are doing.

@mat-hek
Copy link
Member

mat-hek commented Oct 23, 2023

Hi @anzaika , good idea ;) I thought about doing it in Bundlex, so you could do something like

config :bundlex, :use_local_natives, "opus"

That way it would work everywhere out of the box. What do you think?

@anzaika
Copy link
Author

anzaika commented Oct 23, 2023

Hi @mat-hek!

Thanks a lot for your comment.

I think in the real world people either install all the necessary packages themselves or expect "batteries to be included". Hence the solution you propose would be very efficient.

The only thing I'm worried about is that it leaves no "escape hatch" for the minority of users who might want to use that specific version of the OPUS library they have modified and built themselves. Do you think this might be the case?

@mat-hek
Copy link
Member

mat-hek commented Oct 23, 2023

Hmm, not sure if I follow. I wanted to say that if we implement this in Bundlex, you'll be able to do

config :bundlex, :use_local_natives, "opus"

and have OPUS loaded from the OS - that would be the escape hatch. It would work for other libs as well, like

config :bundlex, :use_local_natives, "swresample"

;)

@anzaika
Copy link
Author

anzaika commented Oct 29, 2023

Oh now I get it, that sounds like a perfect solution. I would be happy to contribute that to Bundlex as well if no-one is currently working on it.

@mat-hek
Copy link
Member

mat-hek commented Oct 30, 2023

@anzaika great, go for it! I'm still unsure about the config key though. Maybe enforce_pkg_config would be better than use_local_natives?

@mat-hek
Copy link
Member

mat-hek commented Nov 23, 2023

Done in membraneframework/bundlex#113

@mat-hek mat-hek closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants