Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump to core 1.0 #7

Merged
merged 7 commits into from
Dec 20, 2023
Merged

bump to core 1.0 #7

merged 7 commits into from
Dec 20, 2023

Conversation

mat-hek
Copy link
Member

@mat-hek mat-hek commented Dec 12, 2023

No description provided.

@mat-hek mat-hek requested a review from Noarkhh December 12, 2023 15:13
Noarkhh
Noarkhh reviewed Dec 12, 2023
View reviewed changes
Copy link

@Noarkhh Noarkhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can wait until I merge plugins to use Precompiled Dependency Provider

@mat-hek mat-hek self-assigned this Dec 13, 2023
@mat-hek
Copy link
Member Author

mat-hek commented Dec 18, 2023

@Noarkhh the dependency provider stuff is all done, right?

@mat-hek mat-hek requested a review from Noarkhh December 19, 2023 14:16
Noarkhh
Noarkhh reviewed Dec 19, 2023
View reviewed changes
README.md Outdated
@@ -13,7 +14,7 @@ The package can be installed by adding `membrane_sdk` to your list of dependenci
```elixir
def deps do
[
{:membrane_sdk, github: "~> 0.1"}
{:membrane_sdk, github: "~> 1.0"}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why github:?

@mat-hek mat-hek requested a review from Noarkhh December 19, 2023 15:09
@mat-hek mat-hek merged commit c0ec7aa into master Dec 20, 2023
3 checks passed
@mat-hek mat-hek deleted the core-1.0 branch December 20, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noarkhh Noarkhh Noarkhh approved these changes

Assignees

@mat-hek mat-hek

Labels
None yet
Projects
Smackore
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mat-hek @Noarkhh