Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MS-52] Update core, bump package version #11

Merged
merged 4 commits into from
Mar 21, 2022

Conversation

balins
Copy link
Member

@balins balins commented Mar 18, 2022

No description provided.

@balins balins requested a review from bblaszkow06 March 18, 2022 10:17
@balins balins self-assigned this Mar 18, 2022
{:membrane_core, "~> 0.8.1"},
{:membrane_caps_audio_raw, "~> 0.5.0"},
{:membrane_file_plugin, "~> 0.8.0", optional: true},
{:membrane_core, "~> 0.9.0"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update to the new core usually involved migration to auto-demands. This version should include that I think, although it won't be a trivial demand removal, a change in logic will be required. PM if you need more details

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created an issue for this in #12

@balins balins requested a review from bblaszkow06 March 21, 2022 12:13
@bblaszkow06 bblaszkow06 merged commit b2e583e into master Mar 21, 2022
@bblaszkow06 bblaszkow06 deleted the MS-52-wav-plugin-update-core branch March 21, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants