Add Serializer #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bblaszkow06
requested changes
Aug 4, 2021
README.md
Outdated
| @@ -4,7 +4,7 @@ | |||
| [](https://hexdocs.pm/membrane_wav_plugin) | |||
| [](https://circleci.com/gh/membraneframework/membrane_wav_plugin) | |||
|
|
|||
| This repository provides WAV Parser. | |||
| Plugin providing elements for managing WAV format. | |||
There was a problem hiding this comment.
Word managing seem a bit out of place here
Suggested change
| Plugin providing elements for managing WAV format. | |
| Plugin providing elements handling audio in WAV file format. |
lib/membrane_wav/serializer.ex
Outdated
| def_output_pad :output, | ||
| mode: :pull, | ||
| availability: :always, | ||
| caps: Caps |
There was a problem hiding this comment.
Technically you're not outputing Raw format but rather WAV, so this requires a new _format definition
lib/membrane_wav/serializer.ex
Outdated
| caps: Caps | ||
|
|
||
| @impl true | ||
| def handle_init(state) do |
There was a problem hiding this comment.
Nitpick, put init doesn't receive state but rather options struct passed defining pipeline spec
There was a problem hiding this comment.
That's true, I will change also in Parser
bblaszkow06
requested changes
Aug 4, 2021
| size = buffers_count * Caps.frames_to_bytes(frames, caps) | ||
|
|
||
| {{:ok, demand: {:input, size}}, state} | ||
| end | ||
|
|
||
| @impl true | ||
| def handle_process(:input, buffer, _context, state) do | ||
| def handle_process(:input, buffer, _context, %{header_created: true} = state) do |
There was a problem hiding this comment.
I'd still add an explicit case raising with human readable error - now it might not be obvious why the element is failing from "Function clause error"
bblaszkow06
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.