Multi get, pluggable hashing and some code cleanup (#1)

.eslintrc.json

@@ -15,7 +15,8 @@
         "semi": [
             2,
             "always"
-        ]
+        ],
+        "no-unused-vars": 0
     },
     "globals": {
         "Promise": "readonly"
@@ -24,5 +25,10 @@
         "node": true,
         "browser": true
     },
+    "parserOptions": {
+        "es6": true,
+        "ecmaVersion": 6,
+        "sourceType": "module"
+    },
     "extends": "eslint:recommended"
 }

.github/workflows/ci.yml

@@ -0,0 +1,25 @@
+name: Node.js CI
+
+on:
+  push:
+    branches: [ $default-branch ]
+  pull_request:
+    branches: [ $default-branch, '*' ]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node-version: [12.x]
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Use Node.js ${{ matrix.node-version }}
+      uses: actions/setup-node@v1
+      with:
+        node-version: ${{ matrix.node-version }}
+    - run: npm ci
+    - run: npm test
+    - run: bin/ensure-clean.sh

.gitignore

@@ -12,6 +12,11 @@ pids
 logs
 results
 build/
+lib/test
 
 node_modules
 npm-debug.log
+.nyc_output/
+
+.vscode
+.DS_Store*

README.md

@@ -5,6 +5,43 @@ MemJS
 [![Build Status](https://secure.travis-ci.org/alevy/memjs.png)](http://travis-ci.org/alevy/memjs?branch=master)
 [![Gitter](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/alevy/memjs?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge)
 
+---
+
+Notion fork of MemJS
+
+## Making Changes
+
+see [this](https://dev.notion.so/notion/Developing-dependencies-locally-6705f66af9a24944ac875c44234e68f1) doc
+
+**Linking**
+
+Clone `memjs`, run `npm install`, link `memjs` to local Notion:
+
+```
+cd ~/memjs
+npm link
+
+cd ~/notion-next
+npm link memjs
+```
+
+**Developing**
+
+Run `npx tsc --watch` in the `memjs` directory.
+
+**Unlinking**
+
+```
+cd ~/notion-next
+npm unlink --no-save package-js
+
+cd ~/package-js/
+npm unlink
+```
+
+---
+
+
 MemJS is a pure Node.js client library for using memcache, in particular, the
 [MemCachier](http://memcachier.com/) service. It
 uses the binary protocol and support SASL authentication.
@@ -65,8 +102,8 @@ Environment variables are only used as a fallback for explicit parameters.
 
 You can start using MemJS immediately from the node console:
 
-    $ var memjs = require('memjs')
-    $ var client = memjs.Client.create()
+    $ const memjs = require('memjs')
+    $ const client = memjs.Client.create()
     $ client.get('hello', function(err, val) { console.log(val); })
 
 If callbacks are not specified, the command calls return promises.

bench/memjs.js

@@ -1,11 +1,11 @@
-var memjs = require("memjs");
-var header = require('header');
-var b = require("benchmark");
+const memjs = require('memjs');
+const header = require('header');
+const b = require('benchmark');
 
 function makeString(n) {
-  var possible = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789";
-  var text = "";
-  var i;
+  const possible = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789';
+  let text = '';
+  let i;
 
   for(i=0; i < n; i++ ) {
     text += possible.charAt(Math.floor(Math.random() * possible.length));
@@ -14,29 +14,29 @@ function makeString(n) {
   return text;
 }
 
-var x = (function() {
-  var suite = new b.Suite();
+let x = (function() {
+  const suite = new b.Suite();
 
-  var headerBuf = Buffer.from([0x81, 1, 7, 0, 4, 0, 0, 1, 0, 0, 0, 9, 0, 0, 0, 0, 0x0a, 0, 0, 0, 0, 0, 0, 0]);
-  var parsedHeader = header.fromBuffer(headerBuf);
+  const headerBuf = Buffer.from([0x81, 1, 7, 0, 4, 0, 0, 1, 0, 0, 0, 9, 0, 0, 0, 0, 0x0a, 0, 0, 0, 0, 0, 0, 0]);
+  const parsedHeader = header.fromBuffer(headerBuf);
 
   suite.add('Header#fromBuffer', function() {
     header.fromBuffer(headerBuf);
   })
-  .add('Header#toBuffer', function() {
-    header.toBuffer(parsedHeader);
-  })
+    .add('Header#toBuffer', function() {
+      header.toBuffer(parsedHeader);
+    })
   // add listeners
-  .on('cycle', function(event) {
-    console.log(String(event.target));
-  })
+    .on('cycle', function(event) {
+      console.log(String(event.target));
+    })
   // run async
-  .run({ 'async': true });
+    .run({ 'async': true });
 }());
 
 x = (function() {
-  var suite = new b.Suite();
-  var responseHeader = {
+  const suite = new b.Suite();
+  const responseHeader = {
     magic: 0x81,
     opcode: 1,
     keyLength: 15,
@@ -47,51 +47,51 @@ x = (function() {
     opaque: 0,
     cas: Buffer.from([0x0a, 0, 0, 0, 0, 0, 0, 0])
   };
-  var buf = Buffer.alloc(24 + 15 + 1024 * 10);
+  const buf = Buffer.alloc(24 + 15 + 1024 * 10);
   header.toBuffer(responseHeader).copy(buf);
   buf.write(makeString(55));
 
-  var server = new memjs.Server();
+  const server = new memjs.Server();
 
-  var dummyFunc = function(arg) {
+  const dummyFunc = function(arg) {
     server.onResponse(dummyFunc);
     return arg;
   };
 
-  var i;
+  let i;
   for (i = 0; i < 10; i++) {
     server.onResponse(dummyFunc);
   }
 
   suite.add('Server#respond', function() {
     server.respond('helloworldthisisatesttohowmuchyouareaversetocopyingoverthestargatecommisionandromanticizingaboutmylifelongpassionforlearningandyieldingtoyourdesires');
   })
-  .add('Server#responseHandler', function() {
-    server.responseHandler(buf);
-  })
+    .add('Server#responseHandler', function() {
+      server.responseHandler(buf);
+    })
   // add listeners
-  .on('cycle', function(event) {
-    console.log(String(event.target));
-  })
+    .on('cycle', function(event) {
+      console.log(String(event.target));
+    })
   // run async
-  .run({ 'async': true });
+    .run({ 'async': true });
 }());
 
 x = (function() {
-  var suite = new b.Suite();
-  var client = memjs.Client.create();
+  const suite = new b.Suite();
+  const client = memjs.Client.create();
 
   suite.cycles = 0;
   suite.add('Client#get', function() {
-    client.get("hello", function(/* err, val */) {
+    client.get('hello', function(/* err, val */) {
       suite.cycles++;
     });
   })
   // add listeners
-  .on('cycle', function(event) {
-    console.log(String(event.target) + "     " + suite.cycles);
-  });
-  client.set("hello", makeString(10240), function(/* err, val */) {
+    .on('cycle', function(event) {
+      console.log(String(event.target) + '     ' + suite.cycles);
+    });
+  client.set('hello', makeString(10240), function(/* err, val */) {
     // run async
     suite.run({ 'async': true });
   });

bench/timers.js

@@ -6,40 +6,40 @@
  * Check how fast various timers are in node.
  */
 
-var Benchmark = require('benchmark');
-var Microtime = require('microtime');
+const Benchmark = require('benchmark');
+const Microtime = require('microtime');
 
-var suite = new Benchmark.Suite();
+const suite = new Benchmark.Suite();
 
 // add tests
 suite.add('Date.now()', function() {
   // system time, not-monotonic, ms
   Date.now();
 })
-.add('Microtime.now()', function() {
+  .add('Microtime.now()', function() {
   // system time, not-monotonic, us (POSIX: gettimeofday)
-  Microtime.now();
-})
-.add('process.hrtime()', function() {
+    Microtime.now();
+  })
+  .add('process.hrtime()', function() {
   // monotonic, ns (returns: [seconds, nanoseconds])
-  process.hrtime();
-})
-.add('process.hrtime() ms-round', function() {
+    process.hrtime();
+  })
+  .add('process.hrtime() ms-round', function() {
   // monotonic, ns (returns: [seconds, nanoseconds])
-  var time = process.hrtime();
-  return (time[0] * 1000) + Math.round(time[1] / 1000000);
-})
-.add('process.hrtime() ms-floor', function() {
+    const time = process.hrtime();
+    return (time[0] * 1000) + Math.round(time[1] / 1000000);
+  })
+  .add('process.hrtime() ms-floor', function() {
   // monotonic, ns (returns: [seconds, nanoseconds])
-  var time = process.hrtime();
-  return (time[0] * 1000) + Math.floor(time[1] / 1000000);
-})
+    const time = process.hrtime();
+    return (time[0] * 1000) + Math.floor(time[1] / 1000000);
+  })
 // add listeners
-.on('cycle', function(event) {
-  console.log(String(event.target));
-})
-.on('complete', function() {
-  console.log('Fastest is ' + this.filter('fastest').map('name'));
-})
+  .on('cycle', function(event) {
+    console.log(String(event.target));
+  })
+  .on('complete', function() {
+    console.log('Fastest is ' + this.filter('fastest').map('name'));
+  })
 // run async
-.run({ 'async': true });
+  .run({ 'async': true });

bin/ensure-clean.sh

@@ -0,0 +1,10 @@
+#!/bin/bash
+
+if [[ -z "$(git status --porcelain)" ]]; then
+  echo "Git looks clean, you're good to go" > /dev/stderr
+else
+  git status
+  git diff
+  echo "ERROR: Git looks dirty, see above. Check in all changes." > /dev/stderr
+  exit 2
+fi

cli.js

@@ -0,0 +1,53 @@
+#! node --inspect
+const MemJS = require(".");
+const client = MemJS.Client.create();
+
+let i = 0;
+
+function next(promise) {
+  const id = i++;
+  const varname = `r${id}`;
+
+  const assign = (r) => {
+    global[varname] = r;
+    global["r"] = r;
+  };
+
+  if (promise.then) {
+    promise.then(
+      (r) => {
+        console.log(`r${id} = resolved`, r);
+        assign(r);
+      },
+      (r) => {
+        console.log(`r${id} = rejected`, r);
+        assign(r);
+      }
+    );
+  } else {
+    console.log(`r${id} =`, promise);
+    assign(promise);
+  }
+}
+
+Object.assign(global, {
+  MemJS,
+  client,
+  next,
+  p: next,
+});
+
+console.log(`
+Run as node --inspect cli.js,
+then open Chrome inspector up and click the little node icon.
+
+MemJS: memjs library export
+client: a client connected to localhost:11211
+p: a function to resolve promises
+
+Example:
+  p(client.get('foo'))
+  r1.cas.toString()
+`);
+
+setInterval(() => {}, 5000);