Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge type property index #855

Merged
merged 6 commits into from
Jun 27, 2024
Merged

Edge type property index #855

merged 6 commits into from
Jun 27, 2024

Conversation

Darych
Copy link
Contributor

@Darych Darych commented Jun 19, 2024 •
edited
Loading

Description

Please briefly explain the changes you made.

Pull request type

Please check what kind of PR this is:

  • Fix or improvement of an existing page
  • New documentation page, release related

Related PRs and issues

PR this doc page is related to:
memgraph/memgraph#1964

Closes:
memgraph/memgraph#662

Checklist:

  • Check all content with Grammarly
  • Perform a self-review of my code
  • Make corresponding changes to the rest of the documentation (consult with the DX team)
  • The build passes locally
  • My changes generate no new warnings or errors
  • Add a corresponding label
  • If release-related, add a product and version label
  • If release-related, add release note on product PR

@Darych Darych self-assigned this Jun 19, 2024
@vercel Vercel
Copy link

vercel bot commented Jun 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 7:48pm

@Darych Darych marked this pull request as draft June 19, 2024 18:12
@Darych Darych mentioned this pull request Jun 19, 2024
Open
7 tasks
@kgolubic kgolubic added Docs Ready - Pending Dev Merge Documentation reviewed and ready; awaiting corresponding dev merge. future release For one of the next versions and removed Docs Ready - Pending Dev Merge Documentation reviewed and ready; awaiting corresponding dev merge. labels Jun 20, 2024
@kgolubic kgolubic changed the base branch from main to memgraph-2-18 June 20, 2024 07:25
@Darych Darych added status: ready PR is ready for review memgraph-2-18 labels Jun 24, 2024
@Darych Darych marked this pull request as ready for review June 24, 2024 18:57
@Darych
Copy link
Contributor Author

Darych commented Jun 25, 2024

@hal-eisen-MG @kgolubic
Which is better?
With empty line in Info section
image
Or without?
image

hal-eisen-MG
hal-eisen-MG approved these changes Jun 25, 2024
View reviewed changes
Copy link

@hal-eisen-MG hal-eisen-MG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hal-eisen-MG
Copy link

@hal-eisen-MG @kgolubic Which is better? With empty line in Info section image Or without? image

With the empty line please

hal-eisen-MG
hal-eisen-MG approved these changes Jun 26, 2024
View reviewed changes
Copy link

@hal-eisen-MG hal-eisen-MG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kgolubic
kgolubic approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@kgolubic kgolubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks OK to me.

@kgolubic kgolubic added Docs Ready - Pending Dev Merge Documentation reviewed and ready; awaiting corresponding dev merge. and removed memgraph-2-18 labels Jun 26, 2024
@Darych Darych merged commit 69b4a8e into memgraph-2-18 Jun 27, 2024
2 checks passed
@Darych Darych deleted the edge-type-property-index branch June 27, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgolubic kgolubic kgolubic approved these changes

@hal-eisen-MG hal-eisen-MG hal-eisen-MG approved these changes

Assignees

@Darych Darych

Labels
Docs Ready - Pending Dev Merge Documentation reviewed and ready; awaiting corresponding dev merge. future release For one of the next versions status: ready PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Darych @hal-eisen-MG @kgolubic