Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added initial support for numpy ndarrays and scalars #208

Merged
merged 2 commits into from
Dec 2, 2022

Conversation

BorisTasevski
Copy link
Contributor

Description

added initial support for numpy ndarrays and scalars

Pull request type

Please delete options that are not relevant.

  • Bugfix

Related issues

Closes (link to issue)

to_cypher_value badly converts numpy objects

@katarinasupe
Copy link
Contributor

katarinasupe commented Dec 2, 2022

Does this change need to be added here too? So that it works when the property of a node is ndarray instead of a list in the class definition? Otherwise, all seems fine.

Copy link
Contributor

@Josipmrden Josipmrden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment

tests/test_utilities.py Show resolved Hide resolved
@BorisTasevski
Copy link
Contributor Author

Does this change need to be added here too? So that it works when the property of a node is ndarray instead of a list in the class definition? Otherwise, all seems fine.

This closes the issue within the transformation module, we can create a separate task to look into the models

@katarinasupe
Copy link
Contributor

Does this change need to be added here too? So that it works when the property of a node is ndarray instead of a list in the class definition? Otherwise, all seems fine.

This closes the issue within the transformation module, we can create a separate task to look into the models

Okay, I opened a new issue for the models, so we don't forget.

@BorisTasevski BorisTasevski merged commit 96bed59 into main Dec 2, 2022
@BorisTasevski BorisTasevski deleted the bugfix/to-cypher-value-with-numpy branch December 2, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants