-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master < T] Pydantic v2 #278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this; I’ve linked this PR to the associated issue
@antepusic it is still not working, problems with some type |
@as51340 we should be careful with migration to Pydantic v2 and how that affects our users and us. This guide might help: https://docs.pydantic.dev/latest/migration/#migration-guide. The conclusion of this PR might also be us not moving to Pydantic v2 for now (if you conclude it's too much work for now). But, notice also what users suggested in the linked issue: #257 (comment) . I also found this in their migration guide that might help: https://docs.pydantic.dev/latest/migration/#continue-using-pydantic-v1-features |
There is also a tool that might help if we migrate: https://docs.pydantic.dev/latest/migration/#code-transformation-tool |
Description
Bumped pydantic to v2.3.0
Pull request type
Please delete options that are not relevant.
Related issues
Delete section if this PR doesn't resolve any issues.
Closes (link to issue)
Checklist:
######################################
Reviewer checklist (the reviewer checks this part)
######################################