Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test-connection.yaml #24

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Update test-connection.yaml #24

merged 1 commit into from
Jul 2, 2024

Conversation

pwretmo
Copy link
Contributor

@pwretmo pwretmo commented May 21, 2024

"{{ .Release.Name }}-memgraph-test" does not generate a unique name, which is required when a helm chart includes multiple instances of the memgraph chart.

For example when a chart has two dependencies on memgraph:

dependencies:
- name: memgraph
  version: ~0.1.0
  repository: https://memgraph.github.io/helm-charts
- name: memgraph
  alias: memgraph2
  version: ~0.1.0
  repository: https://memgraph.github.io/helm-charts

"{{ .Release.Name }}-memgraph-test" does not generate a unique name, which is required when a helm chart includes multiple instances of the memgraph chart.
@katarinasupe
Copy link
Collaborator

Hi @pwretmo, thank you for the contribution. The plan is to wrap up #22 tomorrow, with Memgraph 2.17. @antejavor, the maintainer, will be back from vacation next week and then he'll review this PR and include it in the next release. I hope that works for you 🙏

@pwretmo
Copy link
Contributor Author

pwretmo commented May 23, 2024

Hi @katarinasupe, thanks for the update! :)

@antejavor antejavor self-assigned this Jul 2, 2024
@antejavor antejavor added this to the v0.1.4 milestone Jul 2, 2024
@antejavor antejavor merged commit 8170505 into memgraph:main Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants