New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CSV export query results module #199
Conversation
As for Pandas, I think it makes it more easier to work with CSV files, but we can check what are the implications of adding another dependency into MAGE. As for the second one, I'm fine with both.
|
@katarinasupe what is benchmarking difference between |
I did not benchmark it @antoniofilipovic. |
@Josipmrden, do you know what is happening with tests? Suddenly they decided to fail 😂 |
Description
I created
csv_query
procedure insideexport_util
module. Find arguments description in docstring.Discussed with @Josipmrden:
pandas
instead ofcsv
- what are the pros? - Usecsv
,pandas
would be new dependency, andcsv
is not.config
as a map or add stream as an argument. Another option is to return thestream
and remove it from the arguments altogether. I vote for this. - The option to always return thestream
is not good with big results, since it always has to write to stream, even if the user only wants to save in file. The config parameter does not make sense for MAGE modules, so we will go withstream
as argument./usr/lib/memgraph/query_modules
instead of/var/lib/memgraph/internal_modules
used for development. Injson()
procedure in this module, I left it to the user to provide the whole path and advised them to provide/usr/lib/memgraph/query_modules/something.json
. This may be a better way to go. - We will go with path and handle potential errorsTODOs:
stream
as argumentexport_util.csv_query()
procedure docs docs#761Pull request type
######################################
Reviewer checklist (the reviewer checks this part)
Module/Algorithm
######################################