Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main < T583] Implement text.join #287

Merged
merged 5 commits into from Aug 11, 2023
Merged

Conversation

imilinovic
Copy link
Collaborator

@imilinovic imilinovic commented Aug 3, 2023

Description

Implement text.join

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

@imilinovic imilinovic added the status: ready PR is ready for review label Aug 3, 2023
@imilinovic imilinovic self-assigned this Aug 3, 2023
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change

@antoniofilipovic antoniofilipovic added status: change PR reviewed - needs changes and removed status: ready PR is ready for review labels Aug 6, 2023
@imilinovic imilinovic added status: ready PR is ready for review and removed status: change PR reviewed - needs changes labels Aug 8, 2023
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@antoniofilipovic antoniofilipovic added status: ship it PR approved and removed status: ready PR is ready for review labels Aug 9, 2023
@antoniofilipovic antoniofilipovic merged commit d4602ee into main Aug 11, 2023
4 checks passed
@antoniofilipovic antoniofilipovic deleted the T583-MAGE-text-join branch August 11, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ship it PR approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants