Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main < T584] Implement meta.stats #296

Merged
merged 29 commits into from Sep 1, 2023
Merged

[main < T584] Implement meta.stats #296

merged 29 commits into from Sep 1, 2023

Conversation

imilinovic
Copy link
Collaborator

@imilinovic imilinovic commented Aug 7, 2023 •
edited by antepusic

Description

Implement meta.stats online and offline version.

Please briefly explain the changes you made here.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

@imilinovic imilinovic added the status: ready PR is ready for review label Aug 7, 2023
@imilinovic imilinovic self-assigned this Aug 7, 2023
@imilinovic imilinovic changed the title [main < T584] Meta.stats [main < T584] Implement meta.stats Aug 7, 2023
antoniofilipovic
antoniofilipovic reviewed Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to take into account multi-threading

cpp/meta_module/algorithm/meta.cpp Outdated Show resolved Hide resolved
cpp/meta_module/algorithm/meta.cpp Show resolved Hide resolved
cpp/meta_module/algorithm/meta.cpp Outdated Show resolved Hide resolved
cpp/meta_module/algorithm/meta.cpp Outdated Show resolved Hide resolved
cpp/meta_module/algorithm/meta.cpp Outdated Show resolved Hide resolved
cpp/meta_module/algorithm/meta.cpp Outdated Show resolved Hide resolved
@antoniofilipovic antoniofilipovic added status: change PR reviewed - needs changes and removed status: ready PR is ready for review labels Aug 9, 2023
Josipmrden
Josipmrden reviewed Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@Josipmrden Josipmrden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, overall good job

cpp/meta_module/algorithm/meta.cpp Show resolved Hide resolved
cpp/meta_module/algorithm/meta.cpp Show resolved Hide resolved
e2e/meta_online_test/test_online_stats_update_4/input.cyp Outdated Show resolved Hide resolved
cpp/meta_module/algorithm/meta.cpp Outdated Show resolved Hide resolved
cpp/meta_module/algorithm/meta.cpp Outdated Show resolved Hide resolved
cpp/meta_module/algorithm/meta.cpp Outdated Show resolved Hide resolved
cpp/meta_module/algorithm/meta.cpp Outdated Show resolved Hide resolved
cpp/meta_module/algorithm/meta.cpp Show resolved Hide resolved
cpp/meta_module/algorithm/meta.hpp Outdated Show resolved Hide resolved
cpp/meta_module/algorithm/meta.hpp Outdated Show resolved Hide resolved
@imilinovic imilinovic added In progress and removed status: change PR reviewed - needs changes labels Aug 27, 2023
antoniofilipovic
antoniofilipovic requested changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes and that should be it

@antoniofilipovic antoniofilipovic added status: change PR reviewed - needs changes and removed In progress labels Aug 28, 2023
@antepusic antepusic self-requested a review August 28, 2023 22:52
@imilinovic imilinovic added status: ready PR is ready for review and removed status: change PR reviewed - needs changes labels Aug 29, 2023
@imilinovic imilinovic mentioned this pull request Aug 31, 2023
Open
6 tasks
antoniofilipovic
antoniofilipovic approved these changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@antepusic antepusic added the status: ship it PR approved label Sep 1, 2023
@antoniofilipovic antoniofilipovic merged commit a5b0896 into main Sep 1, 2023
4 checks passed
@antoniofilipovic antoniofilipovic deleted the T584-MAGE-meta-stats branch September 1, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josipmrden Josipmrden Josipmrden left review comments

@antepusic antepusic antepusic approved these changes

@antoniofilipovic antoniofilipovic antoniofilipovic approved these changes

@ind1xa ind1xa Awaiting requested review from ind1xa

@mpintaric55334 mpintaric55334 Awaiting requested review from mpintaric55334

Assignees

@imilinovic imilinovic

Labels
status: ready PR is ready for review status: ship it PR approved
Projects
mage
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@imilinovic @Josipmrden @antepusic @antoniofilipovic @ind1xa