New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[E-export < T338] Implement export_csv_graph #325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I suggested few changes what to do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left a few comments. Two of them relate to several files so I’m posting them here:
- Line breaks:
csv.writer
chooses the system-appropriate line break, but it’s safer to usesplit(data, "\n")
in the tests (some systems use just"\n"
, andtrim
will remove the"\r"
anyway) - I think the tests would be easier to follow if you changed the last line of the test query to
RETURN row[1] AS labels, row[7] AS type;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last few changes
5a96780
to
e15be64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved 🚀
Before merging, just make sure to rename separateHeader
and address this previous comment of mine.
Description
Please briefly explain the changes you made here.
Pull request type
Related issues
Delete if this PR doesn't resolve any issues. Link the issue if it does.
######################################
Reviewer checklist (the reviewer checks this part)
Module/Algorithm
######################################