Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E-export < T338] Implement export_csv_graph #325

Merged
merged 11 commits into from Sep 7, 2023

Conversation

mpintaric55334
Copy link
Contributor

Description

Please briefly explain the changes you made here.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I suggested few changes what to do

e2e/export_util_test/test_export_csv_graph/input.cyp Outdated Show resolved Hide resolved
python/export_util.py Outdated Show resolved Hide resolved
python/export_util.py Outdated Show resolved Hide resolved
python/export_util.py Outdated Show resolved Hide resolved
python/export_util.py Outdated Show resolved Hide resolved
python/export_util.py Outdated Show resolved Hide resolved
python/export_util.py Outdated Show resolved Hide resolved
python/export_util.py Outdated Show resolved Hide resolved
python/export_util.py Outdated Show resolved Hide resolved
python/export_util.py Outdated Show resolved Hide resolved
@antoniofilipovic antoniofilipovic added status: change PR reviewed - needs changes and removed status: ready PR is ready for review labels Aug 28, 2023
@mpintaric55334 mpintaric55334 added status: ready PR is ready for review and removed status: change PR reviewed - needs changes labels Aug 29, 2023
Copy link
Collaborator

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a few comments. Two of them relate to several files so I’m posting them here:

  • Line breaks: csv.writer chooses the system-appropriate line break, but it’s safer to use split(data, "\n") in the tests (some systems use just "\n", and trim will remove the "\r" anyway)
  • I think the tests would be easier to follow if you changed the last line of the test query to RETURN row[1] AS labels, row[7] AS type;

python/export_util.py Outdated Show resolved Hide resolved
python/export_util.py Outdated Show resolved Hide resolved
e2e/export_util_test/test_export_csv_graph1/test.yml Outdated Show resolved Hide resolved
e2e/export_util_test/test_export_csv_graph2/test.yml Outdated Show resolved Hide resolved
python/export_util.py Show resolved Hide resolved
@antepusic antepusic added status: change PR reviewed - needs changes and removed status: ready PR is ready for review labels Aug 30, 2023
@mpintaric55334 mpintaric55334 added status: ready PR is ready for review and removed status: change PR reviewed - needs changes labels Sep 4, 2023
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last few changes

@antoniofilipovic antoniofilipovic added status: change PR reviewed - needs changes and removed status: ready PR is ready for review labels Sep 5, 2023
@mpintaric55334 mpintaric55334 added status: ready PR is ready for review and removed status: change PR reviewed - needs changes labels Sep 6, 2023
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Collaborator

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 🚀
Before merging, just make sure to rename separateHeader and address this previous comment of mine.

python/export_util.py Show resolved Hide resolved
@antoniofilipovic antoniofilipovic merged commit 9e7dadc into E-add-export-functions Sep 7, 2023
3 of 4 checks passed
@antoniofilipovic antoniofilipovic deleted the T338-MAGE-csv_graph branch September 7, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready PR is ready for review type: module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants