Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main < T622] Add convert str2object #326

Merged
merged 35 commits into from Sep 7, 2023
Merged

[main < T622] Add convert str2object #326

merged 35 commits into from Sep 7, 2023

Conversation

mpintaric55334
Copy link
Contributor

Description

Please briefly explain the changes you made here.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

idoraban and others added 24 commits August 2, 2023 09:09
add initial structure
de3e42b
implement date.parse
8a0816a
remove cpp date module
bc74ca0
rename python date module
1f3de7e
remove cpp date module
d3bae6b
add date.format draft
7653423
add e2e date.format tests
92360ea
implement label.exists and e2e tests for it
f322d38
add missing endline
39bec4e
edit wrong procedure call
5b41866
edit by review comments
eb487ab
edit typing error
84464b4
format files with black
5a863a3
@antoniofilipovic
Merge branch 'main' into T585-T586-MAGE-implement-date
71c6435
@imilinovic
Merge branch 'main' into T585-T586-MAGE-implement-date
995fe4d
@antoniofilipovic
Merge branch 'main' into T585-T586-MAGE-implement-date
cdd5071
@ind1xa
Merge branch 'main' into T510-MAGE-implement-label
07ed16d
@antepusic
Merge pull request #304 from memgraph/T510-MAGE-implement-label
158919a 
[main < T510] Implement label.exists
@ind1xa
Merge branch 'main' into T585-T586-MAGE-implement-date
456a7ba
@antepusic
Merge pull request #291 from memgraph/T585-T586-MAGE-implement-date
e59093a 
[main < T585 T586] Implement date functions
@mpintaric55334
COnvert
ca33435
@mpintaric55334
Implement convert str2object
85458a3
@mpintaric55334
Implement str2object
476066c
@mpintaric55334
Implement str2object
4e59952
@mpintaric55334 mpintaric55334 added the status: ready PR is ready for review label Aug 23, 2023
@mpintaric55334 mpintaric55334 self-assigned this Aug 23, 2023
@antepusic antepusic added status: ship it PR approved and removed status: ready PR is ready for review labels Aug 30, 2023
@antepusic antepusic self-requested a review September 4, 2023 18:50
antepusic
antepusic requested changes Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d approved this PR before, but #322 has been merged and checks are still failing – just a heads-up for us not to merge this

@antepusic antepusic added status: checks failing status: change PR reviewed - needs changes and removed status: ship it PR approved labels Sep 4, 2023
antoniofilipovic
antoniofilipovic reviewed Sep 5, 2023
View reviewed changes
python/convert.py Outdated Show resolved Hide resolved
antoniofilipovic
antoniofilipovic requested changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few last changes

@antepusic antepusic removed the status: change PR reviewed - needs changes label Sep 5, 2023
@antepusic antepusic self-requested a review September 5, 2023 09:29
@antoniofilipovic antoniofilipovic added the status: ship it PR approved label Sep 6, 2023
@mpintaric55334 mpintaric55334 added status: discuss it PR commented - needs discussion and removed status: checks failing labels Sep 7, 2023
@antoniofilipovic antoniofilipovic merged commit 9fdeb79 into main Sep 7, 2023
4 checks passed
@antoniofilipovic antoniofilipovic deleted the T-add-convert-str2object branch September 7, 2023 12:06
@mpintaric55334 mpintaric55334 mentioned this pull request Sep 11, 2023
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antepusic antepusic antepusic approved these changes

@antoniofilipovic antoniofilipovic antoniofilipovic approved these changes

@tonilastre tonilastre Awaiting requested review from tonilastre

@Josipmrden Josipmrden Awaiting requested review from Josipmrden

Assignees

@mpintaric55334 mpintaric55334

Labels
status: discuss it PR commented - needs discussion status: ship it PR approved type: module
Projects
mage
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mpintaric55334 @antepusic @antoniofilipovic @imilinovic @ind1xa