New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main < T load, parse] Implement xml.load and xml.parse #329
Conversation
[main < T510] Implement label.exists
[main < T585 T586] Implement date functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks solid and does the job, just make sure to do this:
- change the tests to return something with a guaranteed order, not maps whose items’ ordering is not guaranteed
- format Python code
@antoniofilipovic The tests use example XMLs from a third-party website. Thinking about reliability, I think it’s better to make our own example XMLs and host them on some Memgraph repo. |
@antepusic @antoniofilipovic shouldnt the map order always be same in tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About map order: The map contains elements from children
, whose value is taken from the ElementTree
parsed by .fromstring
.
result[children_name] = [
parse_element(child, simple) for child in children
]
After checking, I think their ordering is consistent so the tests are fine in that respect.
@antepusic I wouldn't do that for now. If it starts failing, we can check then. |
@antepusic so is PR ready to be merged or not? |
It’s ready then! 🚀 |
47d9152
to
2b310e5
Compare
Description
Please briefly explain the changes you made here.
Pull request type
Related issues
Delete if this PR doesn't resolve any issues. Link the issue if it does.
######################################
Reviewer checklist (the reviewer checks this part)
Module/Algorithm
######################################