Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main < T647] Add correctness testing for path output #355

Merged
merged 47 commits into from
Oct 23, 2023
Merged

[main < T647] Add correctness testing for path output #355

merged 47 commits into from
Oct 23, 2023

Conversation

mpintaric55334
Copy link
Contributor

Description

Please briefly explain the changes you made here.

Added an option in correctness testing, to see if output of path results is equal to one another. The order of the paths in the result is not important, because the paths will be sorted.

Pull request type

  • Feature

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

idoraban and others added 30 commits August 2, 2023 09:09
add initial structure
de3e42b
implement date.parse
8a0816a
remove cpp date module
bc74ca0
rename python date module
1f3de7e
remove cpp date module
d3bae6b
add date.format draft
7653423
add e2e date.format tests
92360ea
implement label.exists and e2e tests for it
f322d38
add missing endline
39bec4e
edit wrong procedure call
5b41866
edit by review comments
eb487ab
edit typing error
84464b4
format files with black
5a863a3
@antoniofilipovic
Merge branch 'main' into T585-T586-MAGE-implement-date
71c6435
@imilinovic
Merge branch 'main' into T585-T586-MAGE-implement-date
995fe4d
@antoniofilipovic
Merge branch 'main' into T585-T586-MAGE-implement-date
cdd5071
@ind1xa
Merge branch 'main' into T510-MAGE-implement-label
07ed16d
@antepusic
Merge pull request #304 from memgraph/T510-MAGE-implement-label
158919a 
[main < T510] Implement label.exists
@ind1xa
Merge branch 'main' into T585-T586-MAGE-implement-date
456a7ba
@antepusic
Merge pull request #291 from memgraph/T585-T586-MAGE-implement-date
e59093a 
[main < T585 T586] Implement date functions
@mpintaric55334
merge
c39f0cd
@mpintaric55334
Merge branch 'main' of https://github.com/memgraph/mage
2aca436
@mpintaric55334
Pull
731774f
@mpintaric55334
Merge branch 'main' of https://github.com/memgraph/mage
fa5f222
@mpintaric55334
Merge branch 'main' of https://github.com/memgraph/mage
0cc8e82
@mpintaric55334
Merge branch 'main' of https://github.com/memgraph/mage
7b334da
@mpintaric55334
Merge branch 'main' of https://github.com/memgraph/mage
6174dbf
@mpintaric55334
Merge branch 'main' of https://github.com/memgraph/mage
c4277cc
@mpintaric55334
Merge branch 'main' of https://github.com/memgraph/mage
128a7b9
@mpintaric55334
Merge branch 'main' of https://github.com/memgraph/mage
991c1c4
imilinovic
imilinovic requested changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@imilinovic imilinovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change and good to go

@imilinovic imilinovic mentioned this pull request Sep 27, 2023
Merged
16 tasks
antoniofilipovic
antoniofilipovic requested changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes left and that is it

e2e_correctness/query_neo_mem.py Outdated Show resolved Hide resolved
e2e_correctness/query_neo_mem.py Outdated Show resolved Hide resolved
e2e_correctness/query_neo_mem.py Outdated Show resolved Hide resolved
e2e_correctness/query_neo_mem.py Outdated Show resolved Hide resolved
@antoniofilipovic antoniofilipovic added status: change PR reviewed - needs changes and removed status: ready PR is ready for review labels Sep 29, 2023
@mpintaric55334 mpintaric55334 added status: ready PR is ready for review and removed status: change PR reviewed - needs changes labels Oct 3, 2023
imilinovic
imilinovic approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@imilinovic imilinovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format with black, otherwise looks good to go

antoniofilipovic
antoniofilipovic reviewed Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two more comments, that is it

e2e_correctness/test_modules.py Outdated Show resolved Hide resolved
e2e_correctness/test_modules.py Outdated Show resolved Hide resolved
mpintaric55334 and others added 2 commits October 11, 2023 14:07
@mpintaric55334 @antoniofilipovic
Update e2e_correctness/test_modules.py
404cb95 
Co-authored-by: Antonio Filipovic <61245998+antoniofilipovic@users.noreply.github.com>
@mpintaric55334 @antoniofilipovic
Update e2e_correctness/test_modules.py
9d09ac5 
Co-authored-by: Antonio Filipovic <61245998+antoniofilipovic@users.noreply.github.com>
@antoniofilipovic antoniofilipovic added status: ship it PR approved and removed status: ready PR is ready for review labels Oct 16, 2023
@antoniofilipovic antoniofilipovic added this to the 1.12.0 milestone Oct 17, 2023
@antoniofilipovic antoniofilipovic merged commit e56adcc into main Oct 23, 2023
2 checks passed
@antoniofilipovic antoniofilipovic deleted the T-add-testing-for-paths branch October 23, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imilinovic imilinovic imilinovic approved these changes

@antoniofilipovic antoniofilipovic antoniofilipovic approved these changes

Assignees

@mpintaric55334 mpintaric55334

Labels
Docs unnecessary Docs unnecessary status: ship it PR approved
Projects
mage
Status: Done
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mpintaric55334 @imilinovic @antoniofilipovic @ind1xa @antepusic