Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main < E-graphQL] Add compatibility for graphQL #358

Merged
merged 38 commits into from
Sep 26, 2023
Merged

[main < E-graphQL] Add compatibility for graphQL #358

merged 38 commits into from
Sep 26, 2023

Conversation

mpintaric55334
Copy link
Contributor

@mpintaric55334 mpintaric55334 commented Sep 15, 2023 •
edited by antoniofilipovic

Description

Change refactor, label, and create procedures to have camelCase output and input params. Change map and collections procedures to functions. Change schema NodeTypeProperties and schema RelTypeProperties to use camel case input and output parameters.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

idoraban and others added 30 commits August 2, 2023 09:09
add initial structure
de3e42b
implement date.parse
8a0816a
remove cpp date module
bc74ca0
rename python date module
1f3de7e
remove cpp date module
d3bae6b
add date.format draft
7653423
add e2e date.format tests
92360ea
implement label.exists and e2e tests for it
f322d38
add missing endline
39bec4e
edit wrong procedure call
5b41866
edit by review comments
eb487ab
edit typing error
84464b4
format files with black
5a863a3
@antoniofilipovic
Merge branch 'main' into T585-T586-MAGE-implement-date
71c6435
@imilinovic
Merge branch 'main' into T585-T586-MAGE-implement-date
995fe4d
@antoniofilipovic
Merge branch 'main' into T585-T586-MAGE-implement-date
cdd5071
@ind1xa
Merge branch 'main' into T510-MAGE-implement-label
07ed16d
@antepusic
Merge pull request #304 from memgraph/T510-MAGE-implement-label
158919a 
[main < T510] Implement label.exists
@ind1xa
Merge branch 'main' into T585-T586-MAGE-implement-date
456a7ba
@antepusic
Merge pull request #291 from memgraph/T585-T586-MAGE-implement-date
e59093a 
[main < T585 T586] Implement date functions
@mpintaric55334
merge
c39f0cd
@mpintaric55334
Merge branch 'main' of https://github.com/memgraph/mage
2aca436
@mpintaric55334
Pull
731774f
@mpintaric55334
Merge branch 'main' of https://github.com/memgraph/mage
fa5f222
@mpintaric55334
Merge branch 'main' of https://github.com/memgraph/mage
0cc8e82
@mpintaric55334
Merge branch 'main' of https://github.com/memgraph/mage
7b334da
@mpintaric55334
Merge branch 'main' of https://github.com/memgraph/mage
6174dbf
@mpintaric55334
Merge branch 'main' of https://github.com/memgraph/mage
c4277cc
@mpintaric55334
Merge branch 'main' of https://github.com/memgraph/mage
128a7b9
@mpintaric55334
Merge branch 'main' of https://github.com/memgraph/mage
991c1c4
@imilinovic imilinovic added the Docs needed Docs needed label Sep 18, 2023
@imilinovic imilinovic mentioned this pull request Sep 18, 2023
Closed
9 tasks
@vpavicic vpavicic mentioned this pull request Sep 20, 2023
Merged
10 tasks
imilinovic and others added 4 commits September 22, 2023 12:07
@imilinovic
[E-GraphQL < T] Change procedures to fit GraphQL (#360)
851b15f 
* renaming and changing to functions
@mpintaric55334 @imilinovic
[E-graphQL < T-collections] Change collections to abide by graphQL (#361
3fc6c32 
)

* Change coll proc to func

* Change namings

* PR changes

---------

Co-authored-by: imilinovic <44698587+imilinovic@users.noreply.github.com>
@mpintaric55334 @antoniofilipovic @imilinovic
[E-graphQL < T- map] Add graphQL support for map (#362)
56b46a8 
* Add graphQL support for map

* Minor fix

* Update cpp/map_module/algorithm/map.cpp

Co-authored-by: Antonio Filipovic <61245998+antoniofilipovic@users.noreply.github.com>

* Update cpp/map_module/algorithm/map.cpp

Co-authored-by: Antonio Filipovic <61245998+antoniofilipovic@users.noreply.github.com>

* Add from nodes test

---------

Co-authored-by: Antonio Filipovic <61245998+antoniofilipovic@users.noreply.github.com>
Co-authored-by: imilinovic <44698587+imilinovic@users.noreply.github.com>
@mpintaric55334 @imilinovic
Fix type properties for graphQL (#363)
b62d032 
Co-authored-by: imilinovic <44698587+imilinovic@users.noreply.github.com>
@mpintaric55334 mpintaric55334 added status: ready PR is ready for review and removed In progress labels Sep 22, 2023
@mpintaric55334 mpintaric55334 marked this pull request as ready for review September 22, 2023 13:41
antoniofilipovic
antoniofilipovic approved these changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@antoniofilipovic antoniofilipovic added status: ship it PR approved and removed status: ready PR is ready for review labels Sep 25, 2023
@antoniofilipovic antoniofilipovic merged commit 6c8cfbd into main Sep 26, 2023
4 checks passed
@antoniofilipovic antoniofilipovic deleted the E-graphQL-compatibility branch September 26, 2023 09:36
@antoniofilipovic
Copy link
Collaborator

@vpavicic release note:
Change refactor, label, and create procedures to have camelCase output and input params. Change map and collections procedures to functions. Change schema NodeTypeProperties and schema RelTypeProperties to use camel case input and output parameters.

@vpavicic vpavicic added this to the 1.12.0 milestone Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoniofilipovic antoniofilipovic antoniofilipovic approved these changes

Assignees

@imilinovic imilinovic

@mpintaric55334 mpintaric55334

Labels
Docs needed Docs needed status: ship it PR approved
Projects
mage
Status: Done
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mpintaric55334 @antoniofilipovic @imilinovic @vpavicic @ind1xa @antepusic