Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main < T] Fix rust failing tests #365

Merged
merged 6 commits into from
Sep 25, 2023
Merged

Conversation

antoniofilipovic
Copy link
Collaborator

Description

The rust thread started panicking on two workflows for handling leap seconds. Check if it is a fluke or an error.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

@antoniofilipovic antoniofilipovic added the status: draft PR is in draft phase label Sep 19, 2023
@antoniofilipovic antoniofilipovic self-assigned this Sep 19, 2023
@antoniofilipovic
Copy link
Collaborator Author

Found issue on this part
https://docs.rs/chrono/latest/chrono/naive/struct.NaiveTime.html
Screenshot from 2023-09-22 11-42-15

@antoniofilipovic antoniofilipovic added status: ready PR is ready for review and removed status: draft PR is in draft phase labels Sep 22, 2023
Copy link
Collaborator

@imilinovic imilinovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go!

@antoniofilipovic antoniofilipovic added status: ship it PR approved and removed status: ready PR is ready for review labels Sep 22, 2023
@antoniofilipovic antoniofilipovic merged commit 326bd4d into main Sep 25, 2023
4 checks passed
@antoniofilipovic antoniofilipovic deleted the fix-cargo-failling-tests branch September 25, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ship it PR approved
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants