-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main < T] Bugfix for map.merge #377
Conversation
[main < T510] Implement label.exists
[main < T585 T586] Implement date functions
This reverts commit 4420226.
@mpintaric55334 it makes sense to add key exists function to C++ API, I agree. Currently seems it is not possible to check if key exists but property value is null |
This PR memgraph/memgraph#1336 in memgraph needs to be merged for this to work, we've added new functionality (KeyExists) in Cpp API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Description
Please briefly explain the changes you made here.
User noticed a bug, that when the second map contains null elements, merge will throw errors. This happened because we checked the existence of keys using At. If we check it like that, if the key exists, but contains null value, it will be as if the key doesnt exist. Instead I made a set of keys, and checked the existence of keys taht way. @antoniofilipovic maybe it would make sense to add some Keys() function to map Cpp API to automatize the checking for key existence.
Pull request type
Related issues
Delete if this PR doesn't resolve any issues. Link the issue if it does.
######################################
Reviewer checklist (the reviewer checks this part)
Module/Algorithm
######################################