Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main < T676] Ignore libmgclient while copying query modules #386

Merged
merged 3 commits into from
Oct 18, 2023
Merged

[main < T676] Ignore libmgclient while copying query modules #386

merged 3 commits into from
Oct 18, 2023

Conversation

imilinovic
Copy link
Collaborator

Description

Libmgclient was getting copied into query modules but it was never intended to be used as a query module.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Issue 357

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

@imilinovic imilinovic added type: bug Something isn't working Docs unnecessary Docs unnecessary labels Oct 11, 2023
@imilinovic imilinovic self-assigned this Oct 11, 2023
mpintaric55334
mpintaric55334 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@mpintaric55334 mpintaric55334 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoniofilipovic antoniofilipovic added this to the 1.12.0 milestone Oct 16, 2023
antoniofilipovic
antoniofilipovic approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@antoniofilipovic antoniofilipovic mentioned this pull request Oct 17, 2023
Closed
@antoniofilipovic antoniofilipovic merged commit 0320955 into main Oct 18, 2023
4 checks passed
@antoniofilipovic antoniofilipovic deleted the T676-filter-libmgclient branch October 18, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoniofilipovic antoniofilipovic antoniofilipovic approved these changes

@mpintaric55334 mpintaric55334 mpintaric55334 approved these changes

Assignees

@imilinovic imilinovic

Labels
Docs unnecessary Docs unnecessary type: bug Something isn't working
Projects
mage
Status: Done
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@imilinovic @antoniofilipovic @mpintaric55334