Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main <T] Fix neighbors.at_hop bug #402

Merged
merged 43 commits into from
Oct 27, 2023
Merged

[main <T] Fix neighbors.at_hop bug #402

merged 43 commits into from
Oct 27, 2023

Conversation

mpintaric55334
Copy link
Contributor

Description

Please briefly explain the changes you made here.

Fixed a bug user wanted to fix. Now, neighbors.at_hop wont throw an exeption when there are no neighbors, instead ti will return nothing. @matea16 tagging you just in case you want to notify the user when this is merged.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.
#374
######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

idoraban and others added 30 commits August 2, 2023 09:09
[main < T585 T586] Implement date functions
@mpintaric55334 mpintaric55334 added type: bug Something isn't working status: ready PR is ready for review Docs unnecessary Docs unnecessary labels Oct 25, 2023
@mpintaric55334 mpintaric55334 added this to the 1.12.0 milestone Oct 25, 2023
@mpintaric55334 mpintaric55334 self-assigned this Oct 25, 2023
@mpintaric55334 mpintaric55334 changed the title T fix neighbors [main <T] Fix neighbors.at_hop bug Oct 25, 2023
Copy link
Collaborator

@imilinovic imilinovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go!

@antoniofilipovic antoniofilipovic merged commit c2b96a3 into main Oct 27, 2023
2 checks passed
@antoniofilipovic antoniofilipovic deleted the T-fix-neighbors branch October 27, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs unnecessary Docs unnecessary status: ready PR is ready for review type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants