Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dockerfile, requirements and test for no ML build #414

Merged
merged 12 commits into from
Dec 18, 2023

Conversation

antoniofilipovic
Copy link
Collaborator

@antoniofilipovic antoniofilipovic commented Nov 13, 2023

Description

The idea of this PR is to add a Dockerfile for build of MAGE without ML, which is often used when shipping customer images

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

Copy link
Collaborator

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having compared this with the existing Dockerfiles, I think this is fit for approving 👍

@MarkoBarisic
Copy link
Collaborator

Do you think tests for no-ML build should be added to ./github/workflows/test.yml or the tests aren't needed because it can be implied from regular tests?

@antoniofilipovic
Copy link
Collaborator Author

Do you think tests for no-ML build should be added to ./github/workflows/test.yml or the tests aren't needed because it can be implied from regular tests?

Oh, nice idea. I think we should add tests most likely because that way we are sure no-ML image also works. Good catch

@antoniofilipovic antoniofilipovic changed the title Add dockerfiles and requirements for no ML build Add dockerfile, requirements and test for no ML build Nov 29, 2023
Copy link

sonarcloud bot commented Dec 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot C 1 Security Hotspot
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Collaborator

@MarkoBarisic MarkoBarisic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge EOD so I can make on demand platform builds available ASAP 💪

@antoniofilipovic antoniofilipovic merged commit 8653871 into main Dec 18, 2023
9 of 10 checks passed
@antoniofilipovic antoniofilipovic deleted the add-dockerfile-no-ml branch December 18, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants