Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify CreateCsvFile behavior to not include newline #415

Merged
merged 2 commits into from Nov 15, 2023

Conversation

cizl
Copy link
Collaborator

@cizl cizl commented Nov 14, 2023

Description

Modifies the behavior of the CreateCsvFile procedure to not include a newline at the end of the line.
This behaviour is required by the Lab.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

@cizl cizl added the bug bug label Nov 14, 2023
@cizl cizl self-assigned this Nov 14, 2023
@cizl cizl added the status: ready PR is ready for review label Nov 14, 2023
@cizl cizl requested a review from tonilastre November 14, 2023 13:29
@antoniofilipovic antoniofilipovic added status: ship it PR approved and removed status: ready PR is ready for review labels Nov 14, 2023
@antoniofilipovic antoniofilipovic merged commit e6b7474 into main Nov 15, 2023
4 checks passed
@antoniofilipovic antoniofilipovic deleted the modify-csv-utils-behaviour branch November 15, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bug status: ship it PR approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants