Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add impl of text.format #423

Merged
merged 2 commits into from Nov 28, 2023
Merged

Add impl of text.format #423

merged 2 commits into from Nov 28, 2023

Conversation

as51340
Copy link
Collaborator

@as51340 as51340 commented Nov 27, 2023

Description

Added query module for text.format based on fmt impl.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Closes #413

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

@as51340 as51340 added the Docs needed Docs needed label Nov 27, 2023
@as51340 as51340 self-assigned this Nov 27, 2023
@as51340
Copy link
Collaborator Author

as51340 commented Nov 27, 2023

@vpavicic changelog: Added text.format query module function for formatting strings using fmt library.

Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@as51340 as51340 merged commit c95646f into main Nov 28, 2023
4 checks passed
@as51340 as51340 deleted the text-format branch November 28, 2023 08:20
@antoniofilipovic antoniofilipovic added this to the 1.13.0 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs needed Docs needed
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Build apoc.text.format alternative
2 participants