New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add md5 function along with the procedure #444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment about a potential inconsistency with data types.
cpp/util_module/algorithm/util.cpp
Outdated
const mgp::List arg_list = arguments[0].ValueList(); | ||
std::string return_string{""}; | ||
for (auto value : arg_list) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try for (auto value : arguments[0].ValueList())
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can apply Ante's comments, and afterwards it is approve from me
@antepusic Please check again when you have time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here’s an approve from me 👍
Before merging, I see that you gave a 👍 for this comment, just don’t forget to push that change
Quality Gate passedIssues Measures |
Description
MD5 function has been added to MAGE and now user can user either the query module or the function in order to calculate
md5
valuesPull request type
######################################
Reviewer checklist (the reviewer checks this part)
Module/Algorithm
######################################
@kgolubic Release note: "Added md5 function along with the procedure"
memgraph/documentation#493