Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add md5 function along with the procedure #444

Merged
merged 15 commits into from Mar 13, 2024
Merged

Add md5 function along with the procedure #444

merged 15 commits into from Mar 13, 2024

Conversation

Josipmrden
Copy link
Collaborator

@Josipmrden Josipmrden commented Feb 23, 2024

Description

MD5 function has been added to MAGE and now user can user either the query module or the function in order to calculate md5 values

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

@kgolubic Release note: "Added md5 function along with the procedure"
memgraph/documentation#493

@Josipmrden Josipmrden added the customer customer label Feb 23, 2024
@Josipmrden Josipmrden self-assigned this Feb 23, 2024
Copy link
Collaborator

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about a potential inconsistency with data types.

cpp/util_module/util_module.cpp Outdated Show resolved Hide resolved
cpp/util_module/algorithm/util.cpp Outdated Show resolved Hide resolved
@Josipmrden Josipmrden added this to the 1.17.0 milestone Feb 27, 2024
cpp/util_module/util_module.cpp Outdated Show resolved Hide resolved
cpp/util_module/algorithm/util.cpp Show resolved Hide resolved
Comment on lines 10 to 12
const mgp::List arg_list = arguments[0].ValueList();
std::string return_string{""};
for (auto value : arg_list) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try for (auto value : arguments[0].ValueList())?

cpp/util_module/algorithm/util.cpp Show resolved Hide resolved
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can apply Ante's comments, and afterwards it is approve from me

@Josipmrden
Copy link
Collaborator Author

@antepusic Please check again when you have time!

Copy link
Collaborator

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here’s an approve from me 👍

Before merging, I see that you gave a 👍 for this comment, just don’t forget to push that change

Copy link

sonarcloud bot commented Mar 13, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Josipmrden Josipmrden modified the milestones: 1.17.0, 1.16.0 Mar 13, 2024
@Josipmrden Josipmrden merged commit 81152ce into main Mar 13, 2024
9 checks passed
@Josipmrden Josipmrden deleted the util-module branch March 13, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer customer Docs needed Docs needed feature feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants