fix comments

memgraph · Jun 20, 2024 · f8153f2 · f8153f2
1 parent b5277f0
commit f8153f2
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/src/coordination/coordinator_cluster_state.cpp b/src/coordination/coordinator_cluster_state.cpp
@@ -221,12 +221,12 @@ void CoordinatorClusterState::SetIsLockOpened(bool is_lock_opened) {
 }
 
 void CoordinatorClusterState::SetReplicationInstances(
-    std::map<std::string, ReplicationInstanceState, std::less<>> const &replication_instances_) {
+    std::map<std::string, ReplicationInstanceState, std::less<>> replication_instances_) {
   auto lock = std::unique_lock{log_lock_};
-  repl_instances_ = replication_instances_;
+  repl_instances_ = std::move(replication_instances_);
 }
 
-void CoordinatorClusterState::SetCurrentMainUUID(utils::UUID const &current_main_uuid) {
+void CoordinatorClusterState::SetCurrentMainUUID(utils::UUID current_main_uuid) {
   auto lock = std::unique_lock{log_lock_};
   current_main_uuid_ = current_main_uuid;
 }

diff --git a/src/coordination/coordinator_state_machine.cpp b/src/coordination/coordinator_state_machine.cpp
@@ -101,7 +101,8 @@ bool CoordinatorStateMachine::HandleMigration(LogStoreVersion stored_version, Lo
           throw std::runtime_error("Failed to retrieve snapshot context from disk");
         }
 
-        ptr<SnapshotCtx> snapshot_ctx = cs_new<SnapshotCtx>();
+        // NOLINTNEXTLINE (misc-const-correctness)
+        auto snapshot_ctx = cs_new<SnapshotCtx>();
         from_json(nlohmann::json::parse(snapshot_ctx_str.value()), *snapshot_ctx);
         snapshots_[parsed_snapshot_id] = snapshot_ctx;
         MG_ASSERT(parsed_snapshot_id == snapshots_[parsed_snapshot_id]->snapshot_->get_last_log_idx(),

diff --git a/src/coordination/include/nuraft/coordinator_cluster_state.hpp b/src/coordination/include/nuraft/coordinator_cluster_state.hpp
@@ -96,11 +96,14 @@ class CoordinatorClusterState {
 
   auto GetCurrentMainUUID() const -> utils::UUID;
 
-  void SetReplicationInstances(std::map<std::string, ReplicationInstanceState, std::less<>> const &);
+  // Setter function used on parsing data from json
+  void SetReplicationInstances(std::map<std::string, ReplicationInstanceState, std::less<>>);
 
+  // Setter function used on parsing data from json
   void SetIsLockOpened(bool);
 
-  void SetCurrentMainUUID(utils::UUID const &);
+  // Setter function used on parsing data from json
+  void SetCurrentMainUUID(utils::UUID);
 
   auto GetInstanceUUID(std::string_view) const -> utils::UUID;