Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master < T0957] Fix storage GC to handle IN_MEMORY_ANALYTICAL #1025

Merged
merged 1 commit into from Jun 23, 2023

Conversation

Ignition
Copy link
Contributor

This fix corrects the garbage collection of our in memory store to handle deletions made while in IN_MEMORY_ANALYTICAL mode. They will now be collected rather than leak.

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

To keep docs changelog up to date, one more thing to do:

  • Write a release note here -> "Deletions made in IN_MEMORY_ANALYTICAL now handled correctly"
  • Tag someone from docs team in the comments

Closes #957

@Ignition Ignition changed the title [master < T] Fix storage GC to handle IN_MEMORY_ANALYTICAL [master < T1025] Fix storage GC to handle IN_MEMORY_ANALYTICAL Jun 20, 2023
@Ignition Ignition changed the title [master < T1025] Fix storage GC to handle IN_MEMORY_ANALYTICAL [master < T0957] Fix storage GC to handle IN_MEMORY_ANALYTICAL Jun 20, 2023
@Ignition Ignition marked this pull request as ready for review June 20, 2023 12:23
Copy link
Contributor

@gvolfing gvolfing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one concern about the e2e tests, other than that I think this is good to go. Great job!

src/storage/v2/storage.cpp Show resolved Hide resolved
src/utils/skip_list.hpp Show resolved Hide resolved
tests/e2e/analytical_mode/common.py Show resolved Hide resolved
tests/e2e/analytical_mode/workloads.yaml Show resolved Hide resolved
@gitbuda gitbuda added this to the mg-v2.9.0 milestone Jun 22, 2023
@Ignition Ignition force-pushed the MG_957_fix_gc_for_analytical branch from 0fbcaa9 to 80ad29b Compare June 22, 2023 18:30
@Ignition Ignition requested a review from gvolfing June 22, 2023 18:30
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems fine, I am a little bit worried about the full scan for doing detach delete.

@gitbuda gitbuda merged commit 5b1ba10 into master Jun 23, 2023
6 checks passed
@gitbuda gitbuda deleted the MG_957_fix_gc_for_analytical branch June 23, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix SHOW STORAGE INFO; is showing wrong vertex count constantly (GC maybe has a bug)
4 participants