-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master < T1026] Add vertex degree to index statistics #1026
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many things going on in the query planner. I think in general the feature makes a lot of sense. However I also think that we should make this always available to users not only when analyze graph is called since use cases are different, one is for optimizing indices, this is for generating query plan.
@vpavicic (haven't still update the docs, will do that today/tomorrow) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, I have few code comments, include them if you have time otherwise feel free to ignore, it won't break in either way
…memgraph/memgraph into T635-add-vertex-degree-to-query-planner
RN: The |
Expanding extra information in
ANALYZE GRAPH
can be crucial for gaining insights on how to execute a particular query. One of such optimizations is counting information on vertex degrees. That way, supernodes don't need to be expanded when doingMERGE
, but the expansion is done the other way around, so less edges need to be verified for checking if the edge exists when doing the merge.[master < Task] PR
To keep docs changelog up to date, one more thing to do:
ANALYZE GRAPH query has been expanded with degree information for all the vertices to enhance MERGE optimizations on supernodes.