-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master < T0849] Add HTTP+GZIP support to LOAD CSV #1027
Conversation
44103f1
to
c1d819f
Compare
16d8431
to
3aeb3f5
Compare
b4df0a4
to
850f8f2
Compare
@vpavicic this will need documentation changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small number of comments
Should now be supported: HTTP, HTTPS, tftp, ftp, and telnet Also isolated csv into its own target
850f8f2
to
50e63d7
Compare
We need to change the following pages: https://memgraph.com/docs/memgraph/import-data/load-csv-clause @Ignition Would you mind creating a PR in the docs repo or hopping on a call today to explain the feature in detail? The changelog message would be something along the lines of: Now you can import data from web-hosted CSV files by passing the URL in the LOAD CSV clause. You can also import files compressed with GZIP or BZIP2 algorithms. |
f2fcd73
to
0ce768d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, I'll add an issue/task to implement e2e test for this 😄
Added network and compression support
Network: http, https, tftp, ftp, and telnet
Compression: gzip, and bzip2
[master < Task] PR
To keep docs changelog up to date, one more thing to do:
closes #849