New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master < T1085] Remove double scan with expand from the planner #1085
Conversation
@Josipmrden Looking at Grafana dashboard it does drop throughput on some of the mgbench workloads. I think we need to understand this some more. The
|
Seems like a good update, but not good results on the mgbench -> investigation needed |
@gitbuda After some talk with @Ignition we see there are no performance degradations on the benchmarks. We will proceed with the removal of the feature. Also, if the need occurs again, we will re-add the optimization with the appropriate benchmark tests that will point whether we have degraded any queries. |
Possibly it is not needed to do double ScanAll in the operator tree but expand from already existing node.
@vpavicic An optimization to the query engine was added in order to prefer at all times scanning + expansion of nodes instead of scanning both source and destination vertices and then expanding to the edge between them.
No need for documentation updates.
[master < Task] PR
To keep docs changelog up to date, one more thing to do: