New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master < T570] Implement hash on mgp::Value #1093
Conversation
…ph/memgraph into T570-MAGE-implement-hash-on-value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few changes and should be good to go. Fix only this what we talked about that we will copy what we need from utils/fnv.hpp inside mgp namespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All seems good now to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it’s all good too!
@imilinovic - a release note please! what's new/improved here? |
@vpavicic Done |
There was a need to use std::unordered_set and std::unordered_map with mgp::Value.
[master < Epic] PR
[master < Task] PR
To keep docs changelog up to date, one more thing to do:
Write a release note here, including added/changed clauses
Inside _mgp.hpp added functions value_get_numeric (value of number in double) and value_is_numeric (returns if mgp_value is numeric, (int or double)).
C++ API:
Added std::hash for mgp::Value and all its subtypes (mgp::Map, mgp::Path, ...)
You are able now able to use them inside hash structures like std::unordered_map and std::unordered_set.
Tag someone from docs team in the comments