Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master < T570] Implement hash on mgp::Value #1093

Merged
merged 11 commits into from Jul 28, 2023

Conversation

imilinovic
Copy link
Contributor

@imilinovic imilinovic commented Jul 21, 2023

There was a need to use std::unordered_set and std::unordered_map with mgp::Value.
[master < Epic] PR

  • Check, and update documentation if necessary
  • Write E2E tests
  • Compare the benchmarking results between the master branch and the Epic branch
  • Provide the full content or a guide for the final git message

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

To keep docs changelog up to date, one more thing to do:

  • Write a release note here, including added/changed clauses
    Inside _mgp.hpp added functions value_get_numeric (value of number in double) and value_is_numeric (returns if mgp_value is numeric, (int or double)).
    C++ API:
    Added std::hash for mgp::Value and all its subtypes (mgp::Map, mgp::Path, ...)
    You are able now able to use them inside hash structures like std::unordered_map and std::unordered_set.

  • Tag someone from docs team in the comments

@imilinovic imilinovic marked this pull request as ready for review July 25, 2023 09:48
@imilinovic imilinovic changed the title [master < T570-MAGE-implement-hash-on-value] Implement hash on mgp::Value [master < T570] Implement hash on mgp::Value Jul 25, 2023
include/mgp.hpp Outdated Show resolved Hide resolved
@imilinovic imilinovic added Ready for review PR is ready for review and removed Ready for review PR is ready for review labels Jul 25, 2023
@imilinovic imilinovic marked this pull request as draft July 25, 2023 09:54
include/mgp.hpp Outdated Show resolved Hide resolved
include/mgp.hpp Outdated Show resolved Hide resolved
include/mgp.hpp Outdated Show resolved Hide resolved
include/mgp.hpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes and should be good to go. Fix only this what we talked about that we will copy what we need from utils/fnv.hpp inside mgp namespace

include/mgp.hpp Outdated Show resolved Hide resolved
@imilinovic imilinovic added the Ready for review PR is ready for review label Jul 26, 2023
@imilinovic imilinovic marked this pull request as ready for review July 26, 2023 13:51
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems good now to me

@antoniofilipovic antoniofilipovic added Ship it PR ready to be merged and removed Ready for review PR is ready for review labels Jul 27, 2023
Copy link
Contributor

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it’s all good too!

@antoniofilipovic antoniofilipovic merged commit 609b9a2 into master Jul 28, 2023
6 checks passed
@antoniofilipovic antoniofilipovic deleted the T570-MAGE-implement-hash-on-value branch July 28, 2023 07:08
@vpavicic
Copy link
Contributor

vpavicic commented Aug 1, 2023

@imilinovic - a release note please! what's new/improved here?

@imilinovic
Copy link
Contributor Author

@vpavicic Done

as51340 pushed a commit that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature Ship it PR ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants