[master < T1099] Add non-const mgp::Value return type for C++ API #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpintaric55334
changed the title
|
@antoniofilipovic can you help me phrase the description better. @vpavicic I will write the documentation when I get the green light and know how from Antonio. |
antoniofilipovic
approved these changes
Jul 25, 2023
antoniofilipovic
added
Ship it
|
@mpintaric55334 @vpavicic for release note: Extend mgp::Value to return subtypes which are modifieable (non-const) |
|
@mpintaric55334 C++ API? |
6 tasks
as51340
pushed a commit
that referenced
this pull request
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using functions defined in mgp::Value, that return the Type of the value, such as ValueList, that extracted mgp::List from mgp::Value, only returned const types. While writing collections query module, there was need to return non const variables so move semantics could be used, this PR does exactly that.
[master < Task] PR
To keep docs changelog up to date, one more thing to do:
Write a release note here
You are now able to extract non const data from mgp::Value @antoniofilipovic could you help me phrase this better, I dont think this is good.
Tag someone from docs team in the comments