New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master < T1110] Add merge optimization to expand during runtime #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josipmrden
changed the title
[master < TXXXX] Add merge optimization to expand during runtime
[master < T1110] Add merge optimization to expand during runtime
Jul 26, 2023
…graph into merge-expand-during-runtime
Ignition
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, made suggestion to push information on edge size to query::VertexAccessor level.
vpavicic
added
Docs - changelog only
Docs - changelog only
Docs needed
Docs needed
and removed
Docs - changelog only
Docs - changelog only
Docs needed
Docs needed
labels
Sep 12, 2023
as51340
pushed a commit
that referenced
this pull request
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expansion during runtime means that not always will the expansion be done from left to right according to EXPLAIN query, but depending on the previous executions and how many edges did we need to check on merge in order to see what's the fewest vector we need to expand.
[master < Task] PR
To keep docs changelog up to date, one more thing to do: