Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master < T1110] Add merge optimization to expand during runtime #1110

Merged
merged 20 commits into from Sep 8, 2023

Conversation

Josipmrden
Copy link
Contributor

Expansion during runtime means that not always will the expansion be done from left to right according to EXPLAIN query, but depending on the previous executions and how many edges did we need to check on merge in order to see what's the fewest vector we need to expand.

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

To keep docs changelog up to date, one more thing to do:

  • Write a release note here, including added/changed clauses
  • Tag someone from docs team in the comments

@Josipmrden Josipmrden added the feature feature label Jul 26, 2023
@Josipmrden Josipmrden added this to the mg-v2.11.0 milestone Jul 26, 2023
@Josipmrden Josipmrden self-assigned this Jul 26, 2023
@Josipmrden Josipmrden changed the title [master < TXXXX] Add merge optimization to expand during runtime [master < T1110] Add merge optimization to expand during runtime Jul 26, 2023
@Josipmrden Josipmrden marked this pull request as ready for review September 4, 2023 10:48
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, made suggestion to push information on edge size to query::VertexAccessor level.

@Josipmrden Josipmrden merged commit 07dea32 into master Sep 8, 2023
6 checks passed
@Josipmrden Josipmrden deleted the merge-expand-during-runtime branch September 8, 2023 15:12
@vpavicic vpavicic added Docs - changelog only Docs - changelog only Docs needed Docs needed and removed Docs - changelog only Docs - changelog only Docs needed Docs needed labels Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs - changelog only Docs - changelog only feature feature
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants