Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master < T1111] Fix local buffer serialization #1111

Merged
merged 5 commits into from
Jul 29, 2023

Conversation

as51340
Copy link
Contributor

@as51340 as51340 commented Jul 26, 2023

[master < Epic] PR

  • Check, and update documentation if necessary
  • Write E2E tests
  • Compare the benchmarking results between the master branch and the Epic branch
  • Provide the full content or a guide for the final git message

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

To keep docs changelog up to date, one more thing to do:

  • Write a release note here, including added/changed clauses
  • Tag someone from docs team in the comments

@as51340 as51340 changed the title Fix local buffer serialization [master < T1111] Fix local buffer serialization Jul 26, 2023
@as51340 as51340 requested a review from Darych July 26, 2023 13:03
@as51340 as51340 assigned katarinasupe and as51340 and unassigned katarinasupe Jul 26, 2023
@as51340 as51340 added the bug bug label Jul 26, 2023
@as51340 as51340 added this to the mg-v2.10.0 milestone Jul 26, 2023
@as51340 as51340 marked this pull request as ready for review July 26, 2023 13:11
tests/unit/storage_rocks.cpp Show resolved Hide resolved
src/storage/v2/property_store.cpp Show resolved Hide resolved
tests/unit/storage_rocks.cpp Show resolved Hide resolved
@as51340 as51340 requested a review from Darych July 28, 2023 07:35
@gitbuda gitbuda merged commit 18bd024 into master Jul 29, 2023
6 checks passed
@gitbuda gitbuda deleted the fix-disk-serialization-bug branch July 29, 2023 17:14
@vpavicic
Copy link
Contributor

vpavicic commented Aug 1, 2023

@as51340 release note?

@as51340
Copy link
Contributor Author

as51340 commented Aug 1, 2023

@vpavicic users actually have something out of it.
Fixed bug when (de)serializing vertex and edge properties to RocksDB when the size of the serialization buffer was exactly 15B.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants