Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master < T1119] Return NULL on map projection from a null value #1119

Merged
merged 13 commits into from
Sep 9, 2023

Conversation

antepusic
Copy link
Contributor

@antepusic antepusic commented Jul 28, 2023

This PR addresses Issue #1118, which is about making map projections from NULL values. In that case, Memgraph should return a NULL value without raising any exceptions.

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

Fix map projection behavior in case of null projection variable

To keep docs changelog up to date, one more thing to do:

  • Write a release note here, including added/changed clauses

We’ve fixed a bug with map projection. If you project from a variable that happens to be null, the map projection will have a null value instead of displaying an error.

  • Tag someone from docs team in the comments

@antepusic antepusic self-assigned this Jul 28, 2023
@antepusic antepusic changed the title [master < ] Return NULL in case of projecting from NULL [master < E1119] Return NULL in case of projecting from NULL Jul 28, 2023
@antepusic antepusic marked this pull request as draft July 28, 2023 06:54
@antepusic antepusic changed the title [master < E1119] Return NULL in case of projecting from NULL [master < E1119] Return NULL on map projection from a null value Jul 28, 2023
@antepusic antepusic linked an issue Jul 28, 2023 that may be closed by this pull request
src/query/interpret/eval.hpp Outdated Show resolved Hide resolved
@gitbuda gitbuda added this to the mg-v2.11.0 milestone Aug 1, 2023
@antepusic antepusic requested review from Josipmrden and antoniofilipovic and removed request for antoniofilipovic August 2, 2023 18:28
@antepusic antepusic added Ready for review PR is ready for review and removed Status - In Progress labels Aug 2, 2023
@antepusic antepusic marked this pull request as ready for review August 2, 2023 18:31
@antepusic antepusic marked this pull request as draft August 3, 2023 07:10
@antepusic antepusic added Status - In Progress and removed Ready for review PR is ready for review labels Aug 4, 2023
@antepusic antepusic changed the title [master < E1119] Return NULL on map projection from a null value [master < T1119] Return NULL on map projection from a null value Aug 31, 2023
@antepusic antepusic marked this pull request as ready for review September 5, 2023 23:34
@antepusic antepusic added Ready for review PR is ready for review and removed Status - In Progress labels Sep 5, 2023
@gitbuda gitbuda merged commit 0403b67 into master Sep 9, 2023
6 checks passed
@gitbuda gitbuda deleted the fix-map-projection-from-null branch September 9, 2023 10:43
@gitbuda gitbuda removed the Ready for review PR is ready for review label Sep 11, 2023
@antepusic
Copy link
Contributor Author

@vpavicic Release note in the original comment

@vpavicic vpavicic added the Docs - changelog only Docs - changelog only label Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bug Docs - changelog only Docs - changelog only
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] Map projection from NULL values
4 participants