-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master < T1119] Return NULL on map projection from a null value #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antepusic
changed the title
[master < ] Return NULL in case of projecting from NULL
[master < E1119] Return NULL in case of projecting from NULL
Jul 28, 2023
antepusic
changed the title
[master < E1119] Return NULL in case of projecting from NULL
[master < E1119] Return NULL on map projection from a null value
Jul 28, 2023
Josipmrden
requested changes
Jul 28, 2023
antepusic
requested review from
Josipmrden and
antoniofilipovic
and removed request for
antoniofilipovic
August 2, 2023 18:28
antepusic
added
Ready for review
PR is ready for review
and removed
Status - In Progress
labels
Aug 2, 2023
…graph/memgraph into fix-map-projection-from-null
antepusic
added
Status - In Progress
and removed
Ready for review
PR is ready for review
labels
Aug 4, 2023
Josipmrden
reviewed
Aug 4, 2023
antepusic
changed the title
[master < E1119] Return NULL on map projection from a null value
[master < T1119] Return NULL on map projection from a null value
Aug 31, 2023
antepusic
added
Ready for review
PR is ready for review
and removed
Status - In Progress
labels
Sep 5, 2023
Josipmrden
approved these changes
Sep 8, 2023
@vpavicic Release note in the original comment |
as51340
pushed a commit
that referenced
this pull request
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #1118, which is about making map projections from NULL values. In that case, Memgraph should return a NULL value without raising any exceptions.
[master < Task] PR
To keep docs changelog up to date, one more thing to do: