Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master < T595-MAGE] Add remove label on c api #1126

Merged
merged 6 commits into from Aug 1, 2023

Conversation

ind1xa
Copy link
Contributor

@ind1xa ind1xa commented Aug 1, 2023

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

To keep docs changelog up to date, one more thing to do:

  • Write a release note here, including added/changed clauses: Users can now call C++ and C API to remove label.
  • Tag someone from docs team in the comments

@ind1xa ind1xa added the Ready for review PR is ready for review label Aug 1, 2023
@ind1xa ind1xa self-assigned this Aug 1, 2023
@antoniofilipovic antoniofilipovic added Ship it PR ready to be merged and removed Ready for review PR is ready for review labels Aug 1, 2023
@antoniofilipovic antoniofilipovic added this to the mg-v2.10.0 milestone Aug 1, 2023
@ind1xa
Copy link
Contributor Author

ind1xa commented Aug 1, 2023

@vpavicic RELEASE NOTE: Users can now call C++ and C API to remove label.

@gitbuda gitbuda merged commit 50a1d1a into master Aug 1, 2023
5 of 6 checks passed
@gitbuda gitbuda deleted the T595-MAGE-add-remove-label branch August 1, 2023 17:24
@vpavicic
Copy link
Contributor

vpavicic commented Aug 2, 2023

@vpavicic RELEASE NOTE: Users can now call C++ and C API to remove label.

@ind1xa With vertex_remove_label() function?

@ind1xa
Copy link
Contributor Author

ind1xa commented Aug 2, 2023

@vpavicic RELEASE NOTE: Users can now call C++ and C API to remove label.

@ind1xa With vertex_remove_label() function?

@vpavicic and Node::RemoveLabel() for c++

@vpavicic
Copy link
Contributor

vpavicic commented Aug 2, 2023

Can I merge it like this:

The C++ API for writing custom query modules now enables removing properties from nodes with RemoveProperty() function and labels with RemoveLabel() function.

@ind1xa
Copy link
Contributor Author

ind1xa commented Aug 2, 2023

sure, just that I wasn't working on RemoveProperty(), that is Matijas PR I think

@vpavicic
Copy link
Contributor

vpavicic commented Aug 2, 2023

Of course, but users don't know that :) and its easier to read when it's compressed into one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ship it PR ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants