New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master < T1131] Set properties C API extension #1131
Conversation
This reverts commit 0d63a4b.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, overall good work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All’s good now to my eyes 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@Josipmrden please before merging check if everything passes on MAGE so that we don't break something on our side |
Reference mage PR: memgraph/mage#338 |
Tests on MAGE pass, closing this. |
@kgolubic Documentation added at documentation#160. |
Add SetProperties into the C++ query module API
++Based on the SetProperties bulk methods, extension of the C API has been made in order to enable bulk insert of properties inside query modules.
@vpavicic 1. Query modules now have the capability to update node and relationship properties in bulk, which is more efficient than doing it one by one
2. Node Properties() and Relationship Properties() getter from the C++ API changed return type from std::map to std::unordered_map to speed execution time. This is a breaking change to this API and it is advised to communicate to the users to check their C++ Query modules for possible code changes in the next version.
[master < Task] PR
To keep docs changelog up to date, one more thing to do: