Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master < T1131] Set properties C API extension #1131

Merged
merged 22 commits into from Sep 4, 2023
Merged

Conversation

Josipmrden
Copy link
Contributor

@Josipmrden Josipmrden commented Aug 1, 2023

++Based on the SetProperties bulk methods, extension of the C API has been made in order to enable bulk insert of properties inside query modules.

@vpavicic 1. Query modules now have the capability to update node and relationship properties in bulk, which is more efficient than doing it one by one
2. Node Properties() and Relationship Properties() getter from the C++ API changed return type from std::map to std::unordered_map to speed execution time. This is a breaking change to this API and it is advised to communicate to the users to check their C++ Query modules for possible code changes in the next version.

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

To keep docs changelog up to date, one more thing to do:

  • Write a release note here, including added/changed clauses
  • Tag someone from docs team in the comments

@Josipmrden Josipmrden added the feature feature label Aug 1, 2023
@Josipmrden Josipmrden added this to the mg-v2.11.0 milestone Aug 1, 2023
@Josipmrden Josipmrden self-assigned this Aug 1, 2023
@Josipmrden Josipmrden changed the title [master < TXXXX] Set properties C API extension [master < T1131] Set properties C API extension Aug 30, 2023
@Josipmrden Josipmrden requested review from antepusic, antoniofilipovic and andrejtonev and removed request for antepusic August 31, 2023 12:12
@Josipmrden Josipmrden marked this pull request as ready for review August 31, 2023 12:13
@Josipmrden Josipmrden removed the request for review from andrejtonev August 31, 2023 12:13
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, overall good work

include/mgp.hpp Show resolved Hide resolved
include/mgp.hpp Show resolved Hide resolved
src/query/procedure/mg_procedure_impl.cpp Show resolved Hide resolved
src/query/procedure/mg_procedure_impl.cpp Outdated Show resolved Hide resolved
src/query/procedure/py_module.cpp Show resolved Hide resolved
src/query/procedure/mg_procedure_impl.cpp Outdated Show resolved Hide resolved
src/query/procedure/mg_procedure_impl.cpp Outdated Show resolved Hide resolved
src/query/procedure/mg_procedure_impl.cpp Outdated Show resolved Hide resolved
src/query/procedure/mg_procedure_impl.cpp Show resolved Hide resolved
src/query/procedure/mg_procedure_impl.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All’s good now to my eyes 👍

Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@antoniofilipovic
Copy link
Collaborator

@Josipmrden please before merging check if everything passes on MAGE so that we don't break something on our side

@Josipmrden
Copy link
Contributor Author

@Josipmrden please before merging check if everything passes on MAGE so that we don't break something on our side

Reference mage PR: memgraph/mage#338

@Josipmrden Josipmrden merged commit 02eab6a into master Sep 4, 2023
6 checks passed
@Josipmrden Josipmrden deleted the set-properties-api branch September 4, 2023 14:17
@Josipmrden
Copy link
Contributor Author

Tests on MAGE pass, closing this.

@antepusic antepusic added Ship it PR ready to be merged and removed Ready for review PR is ready for review Ship it PR ready to be merged labels Sep 4, 2023
@vpavicic vpavicic added Docs - changelog only Docs - changelog only Docs needed Docs needed and removed Docs - changelog only Docs - changelog only labels Sep 12, 2023
@antepusic
Copy link
Contributor

@kgolubic Documentation added at documentation#160.

as51340 pushed a commit that referenced this pull request Nov 10, 2023
Add SetProperties into the C++ query module API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs needed Docs needed feature feature
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants