Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master < ] Fix segfault based on issue #874 #1175

Merged
merged 13 commits into from Sep 9, 2023
Merged

[master < ] Fix segfault based on issue #874 #1175

merged 13 commits into from Sep 9, 2023

Conversation

DavIvek
Copy link
Contributor

@DavIvek DavIvek commented Aug 18, 2023

This PR is about handling queries in which we want to set a property of a null label, for example, SET null.a = 1. This type of query would cause a segmentation fault and would crash the database. To prevent this, QueryRunTimeException will be thrown.

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

To keep docs changelog up to date, one more thing to do:

  • Write a release note here, including added/changed clauses
  • Tag someone from docs team in the comments

@vpavicic

@gitbuda gitbuda changed the title [master < ] Fix 871 segfault [master < ] Fix 874 segfault issue Aug 18, 2023
@gitbuda gitbuda added the bug bug label Aug 23, 2023
@gitbuda gitbuda added this to the mg-v2.11.0 milestone Aug 23, 2023
@DavIvek DavIvek marked this pull request as ready for review August 23, 2023 16:22
@gitbuda
Copy link
Member

gitbuda commented Aug 23, 2023

Copy link
Contributor

@Ignition Ignition left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have better insight into the root cause.
This is a problem with operator creation.
SetProperty can handle null values at execution, for example UNWIND [null] AS x SET x.a = 1 is fine. So what is it about construction of operators that has an issue with null literals for example SET null.a = 1?

@Josipmrden
Copy link
Contributor

No comments from my side on the code except:

  • branch name could be better (e.g. fix-crash-on-null-values-for-switch-case)
  • Update the info for PR describing what is the fix about and on what query it works.

@DavIvek
Copy link
Contributor Author

DavIvek commented Sep 1, 2023

Even though throwing this exception isn't the solution to a problem with operator creation, it will prevent segmentation fault. We can leave issue #874 open and for mg-v2.12.0 find the root cause of the problem.

@DavIvek DavIvek added Ready for review PR is ready for review and removed Status - In Progress labels Sep 2, 2023
@gitbuda gitbuda changed the title [master < ] Fix 874 segfault issue [master < ] Fix segfault based on issue #874 Sep 8, 2023
@gitbuda gitbuda merged commit 9e4babc into master Sep 9, 2023
6 checks passed
@gitbuda gitbuda deleted the fix-871 branch September 9, 2023 06:04
@gitbuda gitbuda added RN needed and removed Ready for review PR is ready for review labels Sep 11, 2023
@vpavicic vpavicic added the Docs - changelog only Docs - changelog only label Oct 24, 2023
as51340 pushed a commit that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bug Docs - changelog only Docs - changelog only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants