New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master < ] Fix segfault based on issue #874 #1175
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have better insight into the root cause.
This is a problem with operator creation.
SetProperty
can handle null values at execution, for example UNWIND [null] AS x SET x.a = 1
is fine. So what is it about construction of operators that has an issue with null literals for example SET null.a = 1
?
No comments from my side on the code except:
|
Even though throwing this exception isn't the solution to a problem with operator creation, it will prevent segmentation fault. We can leave issue #874 open and for mg-v2.12.0 find the root cause of the problem. |
This PR is about handling queries in which we want to set a property of a null label, for example,
SET null.a = 1
. This type of query would cause a segmentation fault and would crash the database. To prevent this, QueryRunTimeException will be thrown.[master < Task] PR
To keep docs changelog up to date, one more thing to do:
@vpavicic