Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master < T1217] Implement InDegree and OutDegree in O(1) #1217

Merged
merged 5 commits into from
Sep 7, 2023

Conversation

mpintaric55334
Copy link
Contributor

While implementing refactor functions, we figured it would be good to implement In and Out degrees to use already made functions in c-api, so the degree getting operation is O(1).

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

To keep docs changelog up to date, one more thing to do:

  • Write a release note here, including added/changed clauses
    Users can now get the In and Out degrees of a node in O(1) in Cpp API.
  • Tag someone from docs team in the comments

@mpintaric55334 mpintaric55334 added the Ready for review PR is ready for review label Sep 1, 2023
@mpintaric55334 mpintaric55334 self-assigned this Sep 1, 2023
@mpintaric55334
Copy link
Contributor Author

@vpavicic willl write docs when PR is reviewed.

@mpintaric55334 mpintaric55334 changed the title [master < T- implement degrees] Implement InDegree and OutDegree in O(1) [master < T] Implement InDegree and OutDegree in O(1) Sep 1, 2023
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good but would modfiy tests

@antoniofilipovic antoniofilipovic added Needs change PR needs change and removed Ready for review PR is ready for review labels Sep 4, 2023
@mpintaric55334 mpintaric55334 added Ready for review PR is ready for review and removed Needs change PR needs change labels Sep 6, 2023
@Josipmrden Josipmrden changed the title [master < T] Implement InDegree and OutDegree in O(1) [master < T1217] Implement InDegree and OutDegree in O(1) Sep 6, 2023
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@antoniofilipovic antoniofilipovic merged commit d9464c6 into master Sep 7, 2023
6 checks passed
@antoniofilipovic antoniofilipovic deleted the Add-in-out-degrees branch September 7, 2023 11:16
@gitbuda gitbuda modified the milestones: mg-v2.12.0, mg-v2.11.0 Sep 9, 2023
@gitbuda gitbuda added RN needed and removed Ready for review PR is ready for review labels Sep 11, 2023
@vpavicic vpavicic added the Docs - changelog only Docs - changelog only label Sep 12, 2023
@vpavicic vpavicic added Docs needed Docs needed and removed Docs - changelog only Docs - changelog only labels Sep 12, 2023
as51340 pushed a commit that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs needed Docs needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants