Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add index count to index info #1229

Merged
merged 8 commits into from Oct 27, 2023
Merged

Add index count to index info #1229

merged 8 commits into from Oct 27, 2023

Conversation

gvolfing
Copy link
Contributor

@gvolfing gvolfing commented Sep 6, 2023

closes: #1207

@gvolfing gvolfing self-assigned this Sep 6, 2023
@Josipmrden Josipmrden changed the title Add index count to index info [master < T1229] Add index count to index info Sep 6, 2023
@gvolfing gvolfing marked this pull request as ready for review September 7, 2023 12:54
@gitbuda gitbuda added the feature feature label Sep 11, 2023
@gitbuda gitbuda added this to the mg-v2.12.0 milestone Sep 11, 2023
@gitbuda gitbuda changed the title [master < T1229] Add index count to index info Add index count to index info Sep 24, 2023
@antoniofilipovic
Copy link
Collaborator

It looks good to me but I just want to check on this approximation how correct it is

gitbuda
gitbuda requested changes Oct 23, 2023
View reviewed changes
Copy link
Member

@gitbuda gitbuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e/replication fails on this PR (after resolving the merge conflict, not sure if it has passed before)

cd tests/e2e
./run.sh "Show while creating invalid state"

Screenshot 2023-10-23 at 10 02 30 PM

@Josipmrden Josipmrden added Importance - I0 Importance - I0 Severity - S3 Severity - S3 Effort - Low Effort - Low labels Oct 27, 2023
@gitbuda gitbuda added the Docs - changelog only Docs - changelog only label Oct 27, 2023
@gitbuda gitbuda merged commit c296dc6 into master Oct 27, 2023
6 checks passed
@gitbuda gitbuda deleted the T1207-MG-add-index-count-to-showinfo branch October 27, 2023 16:13
as51340 pushed a commit that referenced this pull request Nov 10, 2023
@gvolfing @as51340
Add index count to index info (#1229)
5f17e68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoniofilipovic antoniofilipovic antoniofilipovic left review comments

@gitbuda gitbuda gitbuda approved these changes

@Josipmrden Josipmrden Josipmrden approved these changes

Assignees

@gvolfing gvolfing

Labels
Docs - changelog only Docs - changelog only Effort - Low Effort - Low feature feature Importance - I0 Importance - I0 incremental Severity - S3 Severity - S3
Projects
No open projects
memgraph-v2 issues
Status: No status
Milestone
mg-v2.12.0
Development

Successfully merging this pull request may close these issues.

Add a way to check the stats and sizes of indexes
4 participants
@gvolfing @antoniofilipovic @gitbuda @Josipmrden