Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master < T963] Fix distinct, no longer impacts other aggregates #1235

Merged
merged 1 commit into from Sep 20, 2023

Conversation

Ignition
Copy link
Contributor

@Ignition Ignition commented Sep 7, 2023

Before a distinct on one aggregate would impact distinct on another aggregate. Fixed the logical error and at the same time did some memory optimisations.

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

To keep docs changelog up to date, one more thing to do:

  • Write a release note here, including added/changed clauses --> "Fixed logical bug in distinct processing of multiple aggregates"
  • Tag someone from docs team in the comments

closes #963

@Ignition Ignition self-assigned this Sep 7, 2023
@Ignition Ignition marked this pull request as ready for review September 8, 2023 13:24
@gitbuda gitbuda added this to the mg-v2.12.0 milestone Sep 9, 2023
@Ignition Ignition added the Docs - changelog only Docs - changelog only label Sep 12, 2023
@Ignition Ignition force-pushed the MG_963_fix_distinct branch 2 times, most recently from 3cc4066 to e538e8b Compare September 16, 2023 16:59
Before a distinct on one aggregate would impact distinct on another
aggregate. Fixed the logical error and at the same time did some memory
optimisations.
@Ignition Ignition merged commit eb4e2b0 into master Sep 20, 2023
6 checks passed
@Ignition Ignition deleted the MG_963_fix_distinct branch September 20, 2023 15:45
as51340 pushed a commit that referenced this pull request Nov 10, 2023
Before a distinct on one aggregate would impact distinct on another
aggregate. Fixed the logical error and at the same time did some memory
optimisations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Fix how DISTINCT influences the rest of the returned results
3 participants