Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master < T1249] Add Path.pop to C++ API #1249

Merged
merged 5 commits into from Sep 19, 2023
Merged

Conversation

imilinovic
Copy link
Contributor

@imilinovic imilinovic commented Sep 14, 2023

There was a need to be able to remove the last element of a path in the C++, C and Python API.

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

To keep docs changelog up to date, one more thing to do:

  • Write a release note here, including added/changed clauses
    You are now able to remove the last element of a path in C++ (path.Pop()) , C (mgp_path_pop) and Python (path.pop()) API
  • Tag someone from docs team in the comments

@imilinovic imilinovic added the feature feature label Sep 14, 2023
@imilinovic imilinovic self-assigned this Sep 14, 2023
@antepusic antepusic marked this pull request as ready for review September 14, 2023 11:01
@antepusic antepusic added the Ready for review PR is ready for review label Sep 14, 2023
Copy link
Contributor

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I think that it makes sense to add a corresponding method to the Python API as well.

@imilinovic imilinovic added Status - In Progress and removed Ready for review PR is ready for review labels Sep 15, 2023
@imilinovic imilinovic marked this pull request as draft September 15, 2023 09:32
@imilinovic imilinovic marked this pull request as ready for review September 18, 2023 06:43
@imilinovic imilinovic added Ready for review PR is ready for review and removed Status - In Progress labels Sep 18, 2023
@imilinovic imilinovic added the Docs needed Docs needed label Sep 18, 2023
@imilinovic
Copy link
Contributor Author

@vpavicic Docs PR

@vpavicic vpavicic modified the milestone: mg-v2.11.0 Sep 19, 2023
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@antoniofilipovic
Copy link
Collaborator

@imilinovic please link PR on which we need it on MAGE side, and on MAGE also add backlink to this PR

@antoniofilipovic antoniofilipovic added Ship it PR ready to be merged and removed Ready for review PR is ready for review labels Sep 19, 2023
@antoniofilipovic antoniofilipovic merged commit 404cdf0 into master Sep 19, 2023
6 checks passed
@antoniofilipovic antoniofilipovic deleted the cpp-api-path-pop branch September 19, 2023 10:37
@antepusic antepusic removed the Ship it PR ready to be merged label Sep 19, 2023
@imilinovic
Copy link
Contributor Author

Used in:
MAGE-PR356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs needed Docs needed feature feature
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants